r82388 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82387‎ | r82388 | r82389 >
Date:10:34, 18 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Remove useless elseif compare. If the else if is doing the inverse (!) of the original if, it's redundant
Modified paths:
  • /trunk/phase3/includes/libs/spyc.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/libs/spyc.php
@@ -125,7 +125,7 @@
126126 $indent += $this->_dumpIndent;
127127 // Yamlize the array
128128 $string .= $this->_yamlizeArray( $value, $indent );
129 - } elseif ( !is_array( $value ) ) {
 129+ } else {
130130 // It doesn't have children. Yip.
131131 $string = $this->_dumpNode( $key, $value, $indent );
132132 }

Status & tagging log