r82282 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82281‎ | r82282 | r82283 >
Date:19:44, 16 February 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Add new message key from r80240 to message file. This way it can be found in Special:AllMessages at least.
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -349,6 +349,7 @@
350350 'nstab-template',
351351 'nstab-help',
352352 'nstab-category',
 353+ 'mainpage-nstab',
353354 ),
354355 'main' => array(
355356 'nosuchaction',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -110,6 +110,7 @@
111111 'markaspatrolledlink',
112112 'newarticletextanon',
113113 'newsectionheaderdefaultlevel',
 114+ 'mainpage-nstab',
114115 'newtalkseparator',
115116 'noarticletextanon',
116117 'number_of_watching_users_RCview',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -956,6 +956,7 @@
957957 'nstab-template' => 'Template',
958958 'nstab-help' => 'Help page',
959959 'nstab-category' => 'Category',
 960+'mainpage-nstab' => '', # do not translate or duplicate this message to other languages
960961
961962 # Main script and global functions
962963 'nosuchaction' => 'No such action',

Sign-offs

UserFlagDate
Hasharinspected19:26, 18 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80240Fix bug 14267 by adding support for a MediaWiki:Mainpage-nstab....dantman08:32, 14 January 2011

Comments

#Comment by Dantman (talk | contribs)   20:10, 16 February 2011

Heh... I had essentially these same changes already in my dirty workspace... I just never committed it because I was unsure of the semantics of the 'nstab' group in messages.inc and if mainpage-nstab really belonged there because it's not a normal nstab and couldn't find anyone in IRC who new about the structure of that part of the i18n system.

Status & tagging log