r82281 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82280‎ | r82281 | r82282 >
Date:19:31, 16 February 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
Fix for r82229, extra title construction that didnt work anyway
Modified paths:
  • /trunk/extensions/DoubleWiki/DoubleWiki_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DoubleWiki/DoubleWiki_body.php
@@ -62,13 +62,11 @@
6363 $this->addMatchingTags ( $text, $match_request );
6464
6565 $langLinks = $out->getLanguageLinks();
66 -
67 - foreach( $langLinks as $l) {
 66+ foreach( $langLinks as $l ) {
6867 $nt = Title::newFromText( $l );
6968 $iw = $nt->getInterwiki();
7069
7170 if ( $iw === $match_request ) {
72 - $nt = Title::newFromText( $langLinks[$match_request] );
7371
7472 $key = wfMemcKey( 'doublewiki', $wgLang->getCode(), $nt->getPrefixedDbKey() );
7573 $cachedText = $wgMemc->get( $key );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82229Partial revert to r82202. Readd the loop, keep a couple of the improvements t...reedy10:22, 16 February 2011

Comments

#Comment by Reedy (talk | contribs)   19:34, 16 February 2011

Lol, artifact of relooping it

Status & tagging log