r82207 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82206‎ | r82207 | r82208 >
Date:01:15, 16 February 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Default commentid to '', so we don't get sent emails linking to a url, and then #c0 after it
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
——@@ -107,7 +107,7 @@
108108
109109 // Add any comments
110110 $commentAdded = false;
111 - $commentId = 0;
 111+ $commentId = '';
112112 if ( strlen( $commentText ) && $this->validPost( 'codereview-post-comment' ) ) {
113113 // $isPreview = $wgRequest->getCheck( 'wpPreview' );
114114 $commentId = $this->mRev->saveComment( $commentText, $review, $parent );

Follow-up revisions

RevisionCommit summaryAuthorDate
r83668revert integer variable used as a string...hashar20:52, 10 March 2011

Comments

#Comment by Reedy (talk | contribs)   23:02, 10 March 2011

Hmm.

We're still getting 


User "^demon" changed the status of MediaWiki.[[Special:Code/MediaWiki/79381|r79381]].

Old Status: new
New Status: ok

Full URL: [http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79381#c0 http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79381#c0]
#Comment by 😂 (talk | contribs)   23:03, 10 March 2011

Well, was this ever merged + deployed? I would imagine we'd still be getting the bad e-mails if not :)

#Comment by Reedy (talk | contribs)   23:04, 10 March 2011

I was more meaning where do those emailes come from with #c0....

Status & tagging log