r83668 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r83667
|
r83668
|
r83669
>
Date:
20:52, 10 March 2011
Author:
hashar
Status:
ok
Tags:
Comment:
revert integer variable used as a string
This was in
r82207
which converted an integer to string although there is a
boolean just under explicitly checking for 0!
Modified paths:
/trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
—
—
@@ -107,7 +107,7 @@
108
108
109
109
// Add any comments
110
110
$commentAdded = false;
111
- $commentId = '';
111
+ $commentId = 0;
112
112
if ( strlen( $commentText ) && $this->validPost( 'codereview-post-comment' ) ) {
113
113
// $isPreview = $wgRequest->getCheck( 'wpPreview' );
114
114
$commentId = $this->mRev->saveComment( $commentText, $review, $parent );
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r82207
Default commentid to '', so we don't get sent emails linking to a url, and th...
reedy
01:15, 16 February 2011
Status & tagging log
14:53, 23 March 2011
😂
(
talk
|
contribs
)
changed the
status
of r83668
[
removed:
new
added:
ok]