r82017 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82016‎ | r82017 | r82018 >
Date:14:58, 12 February 2011
Author:platonides
Status:reverted
Tags:
Comment:
Follow up r81883. Readd the extension. This kind of breaks the tempnam() guarantee, but otherwise with no extension the uploader returns UploadBase::FILETYPE_MISSING, not UploadBase::SUCCESS.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/UploadTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/UploadTest.php
@@ -77,7 +77,7 @@
7878
7979 // Helper used to create an empty file of size $size.
8080 private function createFileOfSize( $size ) {
81 - $filename = tempnam( wfTempDir(), "mwuploadtest" );
 81+ $filename = tempnam( wfTempDir(), "mwuploadtest" ) . ".txt";
8282
8383 $fh = fopen( $filename, 'w' );
8484 ftruncate( $fh, $size );

Follow-up revisions

RevisionCommit summaryAuthorDate
r82018Do r82017 the right way. Fix pointed by Bryan.platonides15:18, 12 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81883Fix for r80992. Remove posix extension requisite. Made to work in non-Unix sy...platonides10:48, 10 February 2011

Status & tagging log