r82017 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r82016
|
r82017
|
r82018
>
Date:
14:58, 12 February 2011
Author:
platonides
Status:
reverted
Tags:
Comment:
Follow up
r81883
. Readd the extension. This kind of breaks the tempnam() guarantee, but otherwise with no extension the uploader returns UploadBase::FILETYPE_MISSING, not UploadBase::SUCCESS.
Modified paths:
/trunk/phase3/tests/phpunit/includes/UploadTest.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/tests/phpunit/includes/UploadTest.php
—
—
@@ -77,7 +77,7 @@
78
78
79
79
// Helper used to create an empty file of size $size.
80
80
private function createFileOfSize( $size ) {
81
- $filename = tempnam( wfTempDir(), "mwuploadtest" );
81
+ $filename = tempnam( wfTempDir(), "mwuploadtest" ) . ".txt";
82
82
83
83
$fh = fopen( $filename, 'w' );
84
84
ftruncate( $fh, $size );
Follow-up revisions
Revision
Commit summary
Author
Date
r82018
Do
r82017
the right way. Fix pointed by Bryan.
platonides
15:18, 12 February 2011
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r81883
Fix for
r80992
. Remove posix extension requisite. Made to work in non-Unix sy...
platonides
10:48, 10 February 2011
Status & tagging log
15:18, 12 February 2011
Platonides
(
talk
|
contribs
)
changed the
status
of r82017
[
removed:
new
added:
reverted]