r82016 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82015‎ | r82016 | r82017 >
Date:14:49, 12 February 2011
Author:btongminh
Status:ok
Tags:
Comment:
Follow-up r81971: Can't use $this->setWarning() in static context, so append the error to the imageinfo array instead
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryImageInfo.php
@@ -325,8 +325,7 @@
326326 }
327327 }
328328 if ( $mto && $mto->isError() ) {
329 - $this->setWarning( 'Error creating thumbnail for ' . $file->getName() .
330 - ': ' . $mto->toText() );
 329+ $vals['thumberror'] = $mto->toText();
331330 }
332331 }
333332 $vals['url'] = $file->getFullURL();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81971* (bug 27199) Thumbnail urls can be fetched for old files as wellbtongminh15:40, 11 February 2011

Status & tagging log