r81898 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81897‎ | r81898 | r81899 >
Date:16:44, 10 February 2011
Author:platonides
Status:ok
Tags:
Comment:
Add profiling to the whole ResourceLoader::makeModuleResponse
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoader.php
@@ -444,6 +444,7 @@
445445 return '/* No modules requested. Max made me put this here */';
446446 }
447447
 448+ wfProfileIn( __METHOD__ );
448449 // Pre-fetch blobs
449450 if ( $context->shouldIncludeMessages() ) {
450451 try {
@@ -524,15 +525,16 @@
525526 }
526527 }
527528
528 - if ( $context->getDebug() ) {
529 - return $exceptions . $out;
530 - } else {
 529+ if ( !$context->getDebug() ) {
531530 if ( $context->getOnly() === 'styles' ) {
532 - return $exceptions . $this->filter( 'minify-css', $out );
 531+ $out = $this->filter( 'minify-css', $out );
533532 } else {
534 - return $exceptions . $this->filter( 'minify-js', $out );
 533+ $out = $this->filter( 'minify-js', $out );
535534 }
536535 }
 536+
 537+ wfProfileOut( __METHOD__ );
 538+ return $exceptions . $out;
537539 }
538540
539541 /* Static Methods */

Follow-up revisions

RevisionCommit summaryAuthorDate
r819211.17wmf1: MFT r81729, r81890, r81891, r81892, r81893, r81894, r81896, r81897,...catrope22:42, 10 February 2011
r85148MFT: r80495, r80610, r80765, r81177, r81490, r81692, r81707, r81729, r81765, ...demon20:11, 1 April 2011

Status & tagging log