r81815 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81814‎ | r81815 | r81816 >
Date:15:07, 9 February 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Much easier to use OutputPage::wrapWikiMsg()
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeStatusListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeStatusListView.php
——@@ -11,7 +11,7 @@
1212 global $wgOut;
1313 $name = $this->mRepo->getName();
1414 $states = CodeRevision::getPossibleStates();
15 - $wgOut->addWikiText( "== " . wfMsg ( "code-field-status" ) . " ==\n" );
 15+ $wgOut->wrapWikiMsg( "== $1 ==\n", 'code-field-status' );
1616
1717 $table_rows = '';
1818 foreach ( $states as $state ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r81822Per Siebrand's comment on r81815: removed useless line breakialex16:11, 9 February 2011

Comments

#Comment by Siebrand (talk | contribs)   15:29, 9 February 2011

Is that newline really needed?

#Comment by IAlex (talk | contribs)   16:12, 9 February 2011

No, removed in r81822.

Status & tagging log