r81814 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81813‎ | r81814 | r81815 >
Date:14:59, 9 February 2011
Author:demon
Status:ok
Tags:
Comment:
Followup r81812: per CR, this could be 0
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -586,7 +586,7 @@
587587 }
588588
589589 // Preg yells if you try to give it an empty string
590 - if( $wgInvalidUsernameCharacters ) {
 590+ if( $wgInvalidUsernameCharacters !== '' ) {
591591 if( preg_match( '/[' . preg_quote( $wgInvalidUsernameCharacters, '/' ) . ']/', $name ) ) {
592592 wfDebugLog( 'username', __METHOD__ .
593593 ": '$name' invalid due to wgInvalidUsernameCharacters" );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81812preg_match() yells about undefined offsets when $wgInvalidUsernameCharacters ...demon13:42, 9 February 2011

Status & tagging log