r81498 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81497‎ | r81498 | r81499 >
Date:00:38, 4 February 2011
Author:laner
Status:deferred
Tags:
Comment:
Ensuring required attributes exist
Modified paths:
  • /trunk/extensions/OpenStackManager/scripts/homedirectorymanager.py (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/scripts/homedirectorymanager.py
@@ -77,6 +77,12 @@
7878 AllUsers = {}
7979 for user in UsersData:
8080 uid = user[1]['uid'][0]
 81+ if 'uidNumber' not in user[1].keys():
 82+ continue
 83+ if 'gidNumber' not in user[1].keys():
 84+ continue
 85+ if 'sshPublicKey' not in user[1].keys():
 86+ continue
8187 # uidNumber and gidNumber come back from LDAP as strings, we need ints here.
8288 uidNumber = int(user[1]['uidNumber'][0])
8389 gidNumber = int(user[1]['gidNumber'][0])

Status & tagging log