r81433 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81432‎ | r81433 | r81434 >
Date:00:00, 3 February 2011
Author:dantman
Status:ok
Tags:
Comment:
Commit some fixes for comments on r77741
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -1727,7 +1727,6 @@
17281728 }
17291729 }
17301730 } elseif ( $option == 'nocopyright' ) {
1731 - $footericons = $this->data['footericons'];
17321731 unset( $footericons['copyright']['copyright'] );
17331732 if ( count( $footericons['copyright'] ) <= 0 ) {
17341733 unset( $footericons['copyright'] );
Index: trunk/phase3/includes/DefaultSettings.php
@@ -2329,11 +2329,13 @@
23302330 * $wgFooterIcons itself is a key/value array.
23312331 * The key is the name of a block that the icons will be wrapped in. The final id varies
23322332 * by skin; Monobook and Vector will turn poweredby into f-poweredbyico while Modern
2333 - * turns it into mw_poweredby. The value is a key/value array of icons. The key may or
2334 - * may not be used by the skin but it can be used to find the icon and unset it or
2335 - * change the icon if needed. This is useful for disabling icons that are set by extensions.
 2333+ * turns it into mw_poweredby.
 2334+ * The value is either key/value array of icons or a string.
 2335+ * In the key/value array the key may or may not be used by the skin but it can
 2336+ * be used to find the icon and unset it or change the icon if needed.
 2337+ * This is useful for disabling icons that are set by extensions.
23362338 * The value should be either a string or an array. If it is a string it will be output
2337 - * directly, however some skins may choose to ignore it. An array is the preferred format
 2339+ * directly as html, however some skins may choose to ignore it. An array is the preferred format
23382340 * for the icon, the following keys are used:
23392341 * src: An absolute url to the image to use for the icon, this is recommended
23402342 * but not required, however some skins will ignore icons without an image
@@ -4352,7 +4354,10 @@
43534355 */
43544356 $wgLicenseTerms = false;
43554357
4356 -/** Set this to some HTML to override the rights icon with an arbitrary logo */
 4358+/**
 4359+ * Set this to some HTML to override the rights icon with an arbitrary logo
 4360+ * @deprecated Use $wgFooterIcons['copyright']['copyright']
 4361+ */
43574362 $wgCopyrightIcon = null;
43584363
43594364 /** Set this to true if you want detailed copyright information forms on Upload. */
Index: trunk/phase3/includes/Skin.php
@@ -1698,7 +1698,7 @@
16991699 if ( is_string( $icon ) ) {
17001700 $html = $icon;
17011701 } else { // Assuming array
1702 - $url = $icon["url"];
 1702+ $url = isset($icon["url"]) ? $icon["url"] : null;
17031703 unset( $icon["url"] );
17041704 if ( isset( $icon["src"] ) && $withImage === 'withImage' ) {
17051705 $html = Html::element( 'img', $icon ); // do this the lazy way, just pass icon data as an attribute array

Follow-up revisions

RevisionCommit summaryAuthorDate
r81434Backport r81433's fixes for comments on r77741 which affect 1.17.dantman00:19, 3 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77741Implement $wgFooterIcons to replace copyrightico and poweredbyico with a flex...dantman20:55, 4 December 2010

Status & tagging log