r81434 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81433‎ | r81434 | r81435 >
Date:00:19, 3 February 2011
Author:dantman
Status:ok
Tags:
Comment:
Backport r81433's fixes for comments on r77741 which affect 1.17.
Modified paths:
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/includes/DefaultSettings.php (modified) (history)
  • /branches/REL1_17/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/DefaultSettings.php
@@ -2318,11 +2318,13 @@
23192319 * $wgFooterIcons itself is a key/value array.
23202320 * The key is the name of a block that the icons will be wrapped in. The final id varies
23212321 * by skin; Monobook and Vector will turn poweredby into f-poweredbyico while Modern
2322 - * turns it into mw_poweredby. The value is a key/value array of icons. The key may or
2323 - * may not be used by the skin but it can be used to find the icon and unset it or
2324 - * change the icon if needed. This is useful for disabling icons that are set by extensions.
 2322+ * turns it into mw_poweredby.
 2323+ * The value is either key/value array of icons or a string.
 2324+ * In the key/value array the key may or may not be used by the skin but it can
 2325+ * be used to find the icon and unset it or change the icon if needed.
 2326+ * This is useful for disabling icons that are set by extensions.
23252327 * The value should be either a string or an array. If it is a string it will be output
2326 - * directly, however some skins may choose to ignore it. An array is the preferred format
 2328+ * directly as html, however some skins may choose to ignore it. An array is the preferred format
23272329 * for the icon, the following keys are used:
23282330 * src: An absolute url to the image to use for the icon, this is recommended
23292331 * but not required, however some skins will ignore icons without an image
@@ -4334,7 +4336,10 @@
43354337 */
43364338 $wgLicenseTerms = false;
43374339
4338 -/** Set this to some HTML to override the rights icon with an arbitrary logo */
 4340+/**
 4341+ * Set this to some HTML to override the rights icon with an arbitrary logo
 4342+ * @deprecated Use $wgFooterIcons['copyright']['copyright']
 4343+ */
43394344 $wgCopyrightIcon = null;
43404345
43414346 /** Set this to true if you want detailed copyright information forms on Upload. */
Index: branches/REL1_17/phase3/includes/Skin.php
@@ -1640,7 +1640,7 @@
16411641 if ( is_string( $icon ) ) {
16421642 $html = $icon;
16431643 } else { // Assuming array
1644 - $url = $icon["url"];
 1644+ $url = isset($icon["url"]) ? $icon["url"] : null;
16451645 unset( $icon["url"] );
16461646 if ( isset( $icon["src"] ) && $withImage === 'withImage' ) {
16471647 $html = Html::element( 'img', $icon ); // do this the lazy way, just pass icon data as an attribute array
Index: branches/REL1_17/phase3/RELEASE-NOTES
@@ -99,6 +99,8 @@
100100 * (bug 26253) $wgPostCommitUpdateList has been removed
101101 * The PHPUnit test suite has been removed from this release due to serious issues
102102 which should be resolved by the 1.18 release
 103+* $wgCopyrightIcon is deprecated and $wgFooterIcons['copyright']['copyright'] should
 104+ be used instead.
103105
104106 === New features in 1.17 ===
105107 * (bug 10183) Users can now add personal styles and scripts to all skins via

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77741Implement $wgFooterIcons to replace copyrightico and poweredbyico with a flex...dantman20:55, 4 December 2010
r81433Commit some fixes for comments on r77741dantman00:00, 3 February 2011

Status & tagging log