r81207 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81206‎ | r81207 | r81208 >
Date:14:19, 30 January 2011
Author:platonides
Status:ok
Tags:
Comment:
ParseMaster is designed to use big regexes, with many starting characters.
It makes sense to pcre_study() them.
Modified paths:
  • /trunk/phase3/includes/libs/JavaScriptDistiller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/libs/JavaScriptDistiller.php
@@ -161,7 +161,7 @@
162162 foreach ($this->_patterns as $reg) {
163163 $regexp .= '(' . substr($reg[self::EXPRESSION], 1, -1) . ')|';
164164 }
165 - $regexp = substr($regexp, 0, -1) . '/';
 165+ $regexp = substr($regexp, 0, -1) . '/S';
166166 $regexp .= ($this->ignoreCase) ? 'i' : '';
167167
168168 $string = $this->_escape($string, $this->escapeChar);

Follow-up revisions

RevisionCommit summaryAuthorDate
r823501.17wmf1: MFT r81207, r82340, r82344 (JS minfier fixes)catrope21:49, 17 February 2011

Status & tagging log