r81208 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81207‎ | r81208 | r81209 >
Date:14:26, 30 January 2011
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
Follow-up r80775: Check for meta.tiff as well.
Bump wgStyleVersion
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.upload.js (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -1597,7 +1597,7 @@
15981598 * to ensure that client-side caches do not keep obsolete copies of global
15991599 * styles.
16001600 */
1601 -$wgStyleVersion = '302';
 1601+$wgStyleVersion = '303';
16021602
16031603 /**
16041604 * This will cache static pages for non-logged-in users to reduce
Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.upload.js
@@ -63,7 +63,7 @@
6464 var img = new Image(),
6565 rotation = 0;
6666
67 - if ( meta && meta.tiff.Orientation ) {
 67+ if ( meta && meta.tiff && meta.tiff.Orientation ) {
6868 rotation = (360 - function () {
6969 // See includes/media/Bitmap.php
7070 switch ( meta.tiff.Orientation.value ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80775Follow-up r79867: Read out EXIF orientation in JavaScript and rotate accordin...btongminh22:34, 22 January 2011

Comments

#Comment by Krinkle (talk | contribs)   23:33, 10 June 2011

$wgStyleVersion doesn't have to be increased by this.

anything in /resources is loaded through ResourceLoader which uses it's own timestamps and caching. wgStyleVersion is deprecated and/or unused.

Status & tagging log