r81152 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r81151
|
r81152
|
r81153
>
Date:
19:32, 28 January 2011
Author:
krinkle
Status:
ok (
Comments
)
Tags:
Comment:
Made mediaWiki JS test suite table no longer sortable. This functionality broke with the introduction of hide/show clickers in
r81126
. But we don't need this so we might as well remove it.
Modified paths:
/trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js
—
—
@@ -83,7 +83,7 @@
84
84
'<p>Below is a list of tests to confirm proper functionality of the mediaWiki JavaScript library</p>'
85
85
+ '<p>' + skinLinksText + '</p>'
86
86
+ '<hr />'
87
- + '<table id="mw-mwutiltest-table" class="wikitable sortable" style="white-space:break; font-family:monospace,\'Courier New\'; width:100%;">'
87
+ + '<table id="mw-mwutiltest-table" class="wikitable" style="white-space:break; font-family:monospace,\'Courier New\'; width:100%;">'
88
88
+ '<tr><th>Exec</th><th>Should return</th><th>Does return</th><th>Equal ?</th></tr>'
89
89
+ '</table>'
90
90
);
Follow-up revisions
Revision
Commit summary
Author
Date
r81154
* Adding cursor:pointer when hovering the headers (which hide/show stuff)...
krinkle
19:38, 28 January 2011
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r81126
JS tests: fold headers, adapt style...
hashar
12:13, 28 January 2011
Comments
#
Comment by
Hashar
(
talk
|
contribs
)
14:41, 29 January 2011
One way to support sorting would be to dynamically hide headers. Looks useless anyway.
Marking 'ok'
Status & tagging log
14:41, 29 January 2011
Hashar
(
talk
|
contribs
)
changed the
status
of r81152
[
removed:
new
added:
ok]