r81154 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81153‎ | r81154 | r81155 >
Date:19:38, 28 January 2011
Author:krinkle
Status:ok
Tags:
Comment:
* Adding cursor:pointer when hovering the headers (which hide/show stuff)
* Remove unneeded parens from r81151.
* Whitespaces

(Follow-up r81151, r81152, r81126)
Modified paths:
  • /trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js
@@ -88,8 +88,10 @@
8989 + '</table>'
9090 );
9191
92 - // Override wikitable padding for <td>
93 - mw.util.addCSS( '#mw-mwutiltest-table tr td { padding:0 !important; }' );
 92+ mw.util.addCSS(
 93+ '#mw-mwutiltest-table tr td { padding:0 !important; }' + // Override wikitable padding for <td>
 94+ '.mw-mwutiltest-head:hover { cursor: pointer; } ' // Header-clicks hide/show the below rows
 95+ );
9496
9597 mw.test.$table = $( 'table#mw-mwutiltest-table' );
9698
@@ -295,7 +297,7 @@
296298 'true (boolean)' );
297299 mw.test.addTest( 'mw.util.validateEmail( "userfoo@ex-ample.org" )',
298300 'true (boolean)' );
299 -
 301+
300302 // jQuery plugins
301303 mw.test.addHead( 'jQuery plugins' );
302304
@@ -337,12 +339,12 @@
338340 if( item[0] == 'HEADER' ) {
339341
340342 // update current header with its tests results
341 - mw.test.$table.find( 'tr#mw-mwutiltest-head' + ( numberOfHeaders ) +' > th' )
 343+ mw.test.$table.find( 'tr#mw-mwutiltest-head' + numberOfHeaders +' > th' )
342344 .html( previousHeadTitle + ' <span style="float:right">('
343345 + 'T: ' + headNumberOfTests
344346 + ' ok: ' + headNumberOfPasseds
345347 + ' partial: ' + headNumberOfPartials
346 - + ' err: ' + headNumberOfErrors
 348+ + ' err: ' + headNumberOfErrors
347349 + ')</span>' );
348350
349351 numberOfHeaders++;
@@ -351,16 +353,16 @@
352354 headNumberOfPasseds = 0;
353355 headNumberOfPartials = 0;
354356 headNumberOfErrors = 0;
355 -
356 - previousHeadTitle = mw.test.addedTests[i][1];
357 -
 357+
 358+ previousHeadTitle = item[1];
 359+
358360 return true;
359361 }
360362
361363 exec = item[0];
362364 shouldreturn = item[1];
363365 shouldcontain = item[2];
364 -
 366+
365367 numberOfTests++;
366368 headNumberOfTests++;
367369 doesReturn = eval( exec );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81126JS tests: fold headers, adapt style...hashar12:13, 28 January 2011
r81151Some adjustments to new functionality from r81133...krinkle19:25, 28 January 2011
r81152Made mediaWiki JS test suite table no longer sortable. This functionality bro...krinkle19:32, 28 January 2011

Status & tagging log