r80956 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r80955‎ | r80956 | r80957 >
Date:04:03, 25 January 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
ProofreadPage partial fix for r79326: change "$str_replace()" to "str_replace()" so we don't get a fatal error on page view.
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage_body.php
——@@ -1316,7 +1316,7 @@
13171317 * @return int
13181318 */
13191319 function query_count( $dbr, $query, $cat ) {
1320 - $query['conds']['cl_to'] = $str_replace( ' ' , '_' , wfMsgForContent( $cat ) );
 1320+ $query['conds']['cl_to'] = str_replace( ' ' , '_' , wfMsgForContent( $cat ) );
13211321 $res = $dbr->select( $query['tables'], $query['fields'], $query['conds'], __METHOD__, array(), $query['joins'] );
13221322
13231323 if( $res && $dbr->numRows( $res ) > 0 ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79326Rewrite some of the Raw SQL buildingreedy04:53, 31 December 2010

Comments

#Comment by Reedy (talk | contribs)   08:15, 25 January 2011

God knows how I managed ending up doing this one...

#Comment by Brion VIBBER (talk | contribs)   17:31, 25 January 2011

We've $all typed a few extra $dollar signs... :D

Status & tagging log