r80955 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80954‎ | r80955 | r80956 >
Date:02:52, 25 January 2011
Author:kaldari
Status:deferred
Tags:
Comment:
adding localization to r80954
Modified paths:
  • /trunk/extensions/ContributionReporting/ContributionReporting.i18n.php (modified) (history)
  • /trunk/extensions/ContributionReporting/FundraiserStatistics_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ContributionReporting/FundraiserStatistics_body.php
@@ -191,12 +191,12 @@
192192 }
193193
194194 $wgOut->addHTML( Xml::openElement( 'div', array( 'id' => 'configtoggle' ) ) );
195 - $wgOut->addHTML( '<a id="customize-chart">Customize</a>' );
 195+ $wgOut->addHTML( '<a id="customize-chart">'.wfMsg( 'fundraiserstats-customize' ).'</a>' );
196196 $wgOut->addHTML( Xml::closeElement( 'div' ) );
197197
198198 $wgOut->addHTML( Xml::openElement( 'form', array( 'method' => 'post', 'id' => 'configform' ) ) );
199199
200 - $years = 'Show the following years:<br/>';
 200+ $years = wfMsg( 'fundraiserstats-show-years' ).'<br/>';
201201 foreach ( $egFundraiserStatisticsFundraisers as $fundraiser ) {
202202 $years .= Xml::check( 'toogle'.$fundraiser['id'], $showYear[$fundraiser['id']], array( 'id' => 'bar-'.$fundraiser['id'], 'class' => 'yeartoggle' ) );
203203 $years .= Xml::label( $fundraiser['id'], 'toogle'.$fundraiser['id'] );
@@ -204,8 +204,8 @@
205205 }
206206 $wgOut->addHTML( Xml::openElement( 'div', array( 'id' => 'configholder' ) ) );
207207 $wgOut->addHTML( $years );
208 - $wgOut->addHTML( 'Time Zone:<br/>' );
209 - $wgOut->addHTML( '&nbsp;'.Xml::listDropDown( 'timezone', $this->dropDownList( range ( -12, 14, 1 ) ), '', $this->timezone, '', 1 ).' (from UTC)' );
 208+ $wgOut->addHTML( wfMsg( 'fundraiserstats-time-zone' ).'<br/>' );
 209+ $wgOut->addHTML( '&nbsp;'.Xml::listDropDown( 'timezone', $this->dropDownList( range ( -12, 14, 1 ) ), '', $this->timezone, '', 1 ).' '.wfMsg( 'fundraiserstats-utc' ) );
210210 $wgOut->addHTML( Xml::closeElement( 'div' ) );
211211
212212 $wgOut->addHTML( Xml::closeElement( 'form' ) );
Index: trunk/extensions/ContributionReporting/ContributionReporting.i18n.php
@@ -93,6 +93,10 @@
9494 'fundraiserstats-tab-maximums' => 'Maximums (USD)',
9595 'fundraiserstats-tab-ytd' => 'Year-to-date (USD)',
9696 'fundraiserstats-instructions' => 'To view statistics for any day, hover the cursor over the bar for that day. Each year is a different color on the chart.',
 97+ 'fundraiserstats-customize' => 'Customize',
 98+ 'fundraiserstats-show-years' => 'Show the following years:',
 99+ 'fundraiserstats-time-zone' => 'Time Zone:',
 100+ 'fundraiserstats-utc' => '(from UTC)',
97101 );
98102
99103 /** Message documentation (Message documentation)
@@ -125,6 +129,7 @@
126130 'fundraiserstats-date' => '{{Identical|Date}}',
127131 'fundraiserstats-day' => '* $1 is the nth day of an annual fundraiser
128132 * $2 is the year/name of a fundraiser',
 133+ 'fundraiserstats-utc' => "Note appearing after time zone select list. UTC stands for Coordinated Universal Time and usually doesn't require translation",
129134 );
130135
131136 /** Afrikaans (Afrikaans)

Follow-up revisions

RevisionCommit summaryAuthorDate
r80959Follow-up r80955: Consistency tweaksraymond08:02, 25 January 2011
r102697MFT r45856, r71558, r71962, r73304, r73309, r75671, r75680, r75726, r76542, r...awjrichards22:02, 10 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80954new customizable graph without localizationkaldari02:43, 25 January 2011

Status & tagging log