r80122 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r80121‎ | r80122 | r80123 >
Date:21:21, 12 January 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
61 uses of $this->opts in SpecialContributions, so explicitally defining variable in class
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
——@@ -29,6 +29,8 @@
3030
3131 class SpecialContributions extends SpecialPage {
3232
 33+ private $opts;
 34+
3335 public function __construct() {
3436 parent::__construct( 'Contributions' );
3537 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r80183Followup r80122, protected, just incase it's needed..reedy18:04, 13 January 2011

Comments

#Comment by Nikerabbit (talk | contribs)   06:39, 13 January 2011

Is explicitally a word? protected seems more appropriate if someone wants to extend/subclass SpecialContributions.

Status & tagging log