r79864 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79863‎ | r79864 | r79865 >
Date:16:01, 8 January 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Followup r74298: add ORDER BY wl_namespace, wl_title to the query in WatchlistEditor.php , rather than conditionally adding an ORDER BY that only seems to play nice on Postgres
Modified paths:
  • /trunk/phase3/includes/WatchlistEditor.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WatchlistEditor.php
——@@ -213,7 +213,7 @@
214214 array( 'wl_namespace', 'wl_title', 'page_id', 'page_len', 'page_is_redirect', 'page_latest' ),
215215 array( 'wl_user' => $user->getId() ),
216216 __METHOD__,
217 - $dbr->implicitOrderby() ? array( ) : array( 'ORDER BY' => 'wl_title' ),
 217+ array( 'ORDER BY' => 'wl_namespace, wl_title' ),
218218 array( 'page' =>
219219 array( 'LEFT JOIN', 'wl_namespace = page_namespace AND wl_title = page_title' ) )
220220 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r805261.17: MFT r78232, r78253, r79722, r79732, r79785, r79817, r79864, r79891, r79...catrope22:19, 18 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74298Make the watchlist query ordering consistent across DBs.greg13:36, 5 October 2010

Comments

#Comment by Catrope (talk | contribs)   16:03, 8 January 2011

This one will have to be merged into 1.17 manually since the surrounding code got refactored after the branch point (raw SQL -> array format).

Status & tagging log