r79817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79816‎ | r79817 | r79818 >
Date:14:04, 7 January 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
LiquidThreads: Fix JS error in lqt.js. It's important to understand that $foo.data( 'bar', baz ) does NOT always return $foo ; for certain values of baz (e.g. undefined, null) it's equivalent to $foo.data( 'bar' ) instead
Modified paths:
  • /trunk/extensions/LiquidThreads/lqt.js (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.js
@@ -102,7 +102,8 @@
103103 var talkpage = $j(this).attr('lqt_talkpage');
104104 var params = {'talkpage' : talkpage, 'method' : 'talkpage_new_thread' };
105105
106 - var container = $j('.lqt-new-thread' ).data('lqt-talkpage', talkpage);
 106+ var container = $j('.lqt-new-thread' );
 107+ container.data('lqt-talkpage', talkpage);
107108
108109 liquidThreads.injectEditForm( params, container );
109110 liquidThreads.currentReplyThread = 0;

Follow-up revisions

RevisionCommit summaryAuthorDate
r805261.17: MFT r78232, r78253, r79722, r79732, r79785, r79817, r79864, r79891, r79...catrope22:19, 18 January 2011

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   00:26, 13 January 2011

This is what people get for being clever.

Status & tagging log