r79787 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79786‎ | r79787 | r79788 >
Date:01:50, 7 January 2011
Author:demon
Status:reverted
Tags:
Comment:
Fixme on r79296, use actual path not repo object
Modified paths:
  • /trunk/extensions/CodeReview/backend/Subversion.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/Subversion.php
@@ -72,7 +72,7 @@
7373 */
7474 function canConnect() {
7575 wfSuppressWarnings();
76 - $result = svn_info( $this->mRepo );
 76+ $result = svn_info( $this->mRepo->getPath() );
7777 wfRestoreWarnings();
7878 return (bool)$result;
7979 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r79788Revert r79787, r79296: just go back to defaulting true. svn_info() is painful...demon01:58, 7 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79296Using undocumented svn_info() in canConnect()demon21:47, 30 December 2010

Status & tagging log