r79788 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79787‎ | r79788 | r79789 >
Date:01:58, 7 January 2011
Author:demon
Status:ok
Tags:
Comment:
Revert r79787, r79296: just go back to defaulting true. svn_info() is painfully slow
Modified paths:
  • /trunk/extensions/CodeReview/backend/Subversion.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/Subversion.php
@@ -64,6 +64,8 @@
6565 class SubversionPecl extends SubversionAdaptor {
6666
6767 /**
 68+ * Just return true for now. svn_info() is too slow to be useful...
 69+ *
6870 * Using undocumented svn_info function. Looking at the source, this has
6971 * existed since version 0.3 of the Pecl extension (per release notes).
7072 * Nobody ever bothered filling in the documentation on php.net though.
@@ -71,10 +73,10 @@
7274 * It throws a warning if the repository does not exist.
7375 */
7476 function canConnect() {
75 - wfSuppressWarnings();
76 - $result = svn_info( $this->mRepo->getPath() );
77 - wfRestoreWarnings();
78 - return (bool)$result;
 77+ //wfSuppressWarnings();
 78+ //$result = svn_info( $this->mRepo );
 79+ //wfRestoreWarnings();
 80+ return true;
7981 }
8082
8183 function getFile( $path, $rev = null ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79296Using undocumented svn_info() in canConnect()demon21:47, 30 December 2010
r79787Fixme on r79296, use actual path not repo objectdemon01:50, 7 January 2011

Status & tagging log