r79750 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79749‎ | r79750 | r79751 >
Date:20:03, 6 January 2011
Author:demon
Status:ok
Tags:
Comment:
Revert r78000 (removing PHP version from environment checks), never got a chance to redo this prettier
Modified paths:
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
@@ -142,6 +142,8 @@
143143 * @return Status
144144 */
145145 public function doEnvironmentChecks() {
 146+ $this->showMessage( 'config-env-php', phpversion() );
 147+
146148 $good = true;
147149
148150 foreach ( $this->envChecks as $check ) {
Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -83,6 +83,7 @@
8484 You can install MediaWiki.',
8585 'config-env-bad' => 'The environment has been checked.
8686 You cannot install MediaWiki.',
 87+ 'config-env-php' => 'PHP $1 is installed.',
8788 'config-unicode-using-utf8' => 'Using Brion Vibber\'s utf8_normalize.so for Unicode normalization.',
8889 'config-unicode-using-intl' => 'Using the [http://pecl.php.net/intl intl PECL extension] for Unicode normalization.',
8990 'config-unicode-pure-php-warning' => "'''Warning''': The [http://pecl.php.net/intl intl PECL extension] is not available to handle Unicode normalization, falling back to slow pure-PHP implementation.

Follow-up revisions

RevisionCommit summaryAuthorDate
r801901.17: MFT first batch of installer changes: r78043, r78231, r78259, r78300, r...catrope20:47, 13 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78000Also ditch PHP thing. We would've bailed for a bad version alreadydemon18:32, 7 December 2010

Status & tagging log