r78000 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77999‎ | r78000 | r78001 >
Date:18:32, 7 December 2010
Author:demon
Status:reverted (Comments)
Tags:
Comment:
Also ditch PHP thing. We would've bailed for a bad version already
Modified paths:
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
@@ -142,8 +142,6 @@
143143 * @return boolean
144144 */
145145 public function doEnvironmentChecks() {
146 - $this->showMessage( 'config-env-php', phpversion() );
147 -
148146 $good = true;
149147
150148 foreach ( $this->envChecks as $check ) {
Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -75,7 +75,6 @@
7676 You can install MediaWiki.</span>', // FIXME: take span out of message.
7777 'config-env-bad' => 'The environment has been checked.
7878 You cannot install MediaWiki.',
79 - 'config-env-php' => 'PHP $1 is installed.',
8079 'config-unicode-using-utf8' => 'Using Brion Vibber\'s utf8_normalize.so for Unicode normalization.',
8180 'config-unicode-using-intl' => 'Using the [http://pecl.php.net/intl intl PECL extension] for Unicode normalization.',
8281 'config-unicode-pure-php-warning' => "'''Warning''': The [http://pecl.php.net/intl intl PECL extension] is not available to handle Unicode normalization, falling back to slow pure-PHP implementation.

Follow-up revisions

RevisionCommit summaryAuthorDate
r79750Revert r78000 (removing PHP version from environment checks), never got a cha...demon20:03, 6 January 2011

Comments

#Comment by MaxSem (talk | contribs)   16:57, 8 December 2010

I don't think it's wise. We should give people the possibility to easily learn their PHP version and c+p it to us.

#Comment by 😂 (talk | contribs)   17:00, 8 December 2010

Per IRC cabal: lets turn this into a pretty table like Special:Version

Status & tagging log