r78300 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78299‎ | r78300 | r78301 >
Date:13:13, 13 December 2010
Author:catrope
Status:ok
Tags:
Comment:
Followup r76220: locateExecutableInDefaultPaths() was made static, so use static calls
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
@@ -570,7 +570,7 @@
571571 $names = array( "gdiff3", "diff3", "diff3.exe" );
572572 $versionInfo = array( '$1 --version 2>&1', 'GNU diffutils' );
573573
574 - $diff3 = $this->locateExecutableInDefaultPaths( $names, $versionInfo );
 574+ $diff3 = self::locateExecutableInDefaultPaths( $names, $versionInfo );
575575
576576 if ( $diff3 ) {
577577 $this->setVar( 'wgDiff3', $diff3 );
@@ -585,7 +585,7 @@
586586 */
587587 protected function envCheckGraphics() {
588588 $names = array( wfIsWindows() ? 'convert.exe' : 'convert' );
589 - $convert = $this->locateExecutableInDefaultPaths( $names, array( '$1 -version', 'ImageMagick' ) );
 589+ $convert = self::locateExecutableInDefaultPaths( $names, array( '$1 -version', 'ImageMagick' ) );
590590
591591 if ( $convert ) {
592592 $this->setVar( 'wgImageMagickConvertCommand', $convert );

Follow-up revisions

RevisionCommit summaryAuthorDate
r801901.17: MFT first batch of installer changes: r78043, r78231, r78259, r78300, r...catrope20:47, 13 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76220Trying to kill install-utils.inc/old install crap:...demon22:16, 6 November 2010

Status & tagging log