r79738 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79737‎ | r79738 | r79739 >
Date:17:41, 6 January 2011
Author:demon
Status:ok
Tags:
Comment:
Followup r79684: forgot to commit a file
Modified paths:
  • /trunk/phase3/maintenance/install.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/install.php
@@ -68,7 +68,13 @@
6969 new CliInstaller( $siteName, $adminName, $this->mOptions );
7070
7171 if ( $this->hasOption( 'env-checks' ) ) {
72 - $installer->doEnvironmentChecks();
 72+ $status = $installer->doEnvironmentChecks();
 73+ if( $status->isGood() ) {
 74+ $installer->showMessage( 'config-env-good' );
 75+ } else {
 76+ $installer->showStatusMessage( $status );
 77+ return;
 78+ }
7379 } else {
7480 $installer->execute();
7581 $installer->writeConfigurationFile( $this->getOption( 'confpath', $IP ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r801901.17: MFT first batch of installer changes: r78043, r78231, r78259, r78300, r...catrope20:47, 13 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79684Move pass/fail message out of doEnvironmentChecks(), return a Status and let ...demon23:20, 5 January 2011

Status & tagging log