r79737 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79736‎ | r79737 | r79738 >
Date:17:39, 6 January 2011
Author:yaron
Status:deferred
Tags:
Comment:
Changed namespace addition to only avoid prefixing with the namespace if that namespace is already in the page name; not if a colon is anywhere in the page name
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_FormStart.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_FormStart.php
@@ -66,8 +66,8 @@
6767 }
6868 if ( $page_name != '' ) {
6969 // Append the namespace prefix to the page name,
70 - // if a namespace was not already entered.
71 - if ( strpos( $page_name, ":" ) === false && $target_namespace != '' )
 70+ // if this namespace was not already entered.
 71+ if ( strpos( $page_name, $target_namespace . ":" ) === false && $target_namespace != '' )
7272 $page_name = $target_namespace . ":" . $page_name;
7373 // find out whether this page already exists,
7474 // and send user to the appropriate form

Status & tagging log