r79709 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79708‎ | r79709 | r79710 >
Date:03:24, 6 January 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Fixup fixme on r67819
Modified paths:
  • /trunk/phase3/includes/parser/Preprocessor_DOM.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Preprocessor_DOM.php
@@ -37,15 +37,14 @@
3838
3939 function newPartNodeArray( $values ) {
4040 //NOTE: DOM manipulation is slower than building & parsing XML! (or so Tim sais)
41 - $xml = "";
42 - $xml .= "<list>";
 41+ $xml = "<list>";
4342
4443 foreach ( $values as $k => $val ) {
4544
4645 if ( is_int( $k ) ) {
4746 $xml .= "<part><name index=\"$k\"/><value>" . htmlspecialchars( $val ) ."</value></part>";
4847 } else {
49 - $xml .= "<part><name>" . htmlspecialchars( $k ) . "</name>=<value>" . htmlspecialchars( $val ) . "</value></part>";
 48+ $xml .= "<part><name>" . htmlspecialchars( $k ) . "</name><value>" . htmlspecialchars( $val ) . "</value></part>";
5049 }
5150 }
5251

Follow-up revisions

RevisionCommit summaryAuthorDate
r79724Followup r79709, re-add equals...reedy15:27, 6 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67819added newPartNodeArray for creating a node with a list of parts form a php ar...daniel15:02, 10 June 2010

Comments

#Comment by Catrope (talk | contribs)   13:52, 6 January 2011

You removed an equals sign that was supposed to be there, see https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/67819#c12725

#Comment by Catrope (talk | contribs)   13:53, 6 January 2011

Since other than that the only thing that's left is a totally minor style change, untagging 1.17

Status & tagging log