r79704 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79703‎ | r79704 | r79705 >
Date:02:30, 6 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix fixme on r71071, if passed type is not in the array returned by getExtensionTypes(), return the other message by default
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
——@@ -246,7 +246,7 @@
247247 */
248248 public static function getExtensionTypeName( $type ) {
249249 $types = self::getExtensionTypes();
250 - return $types[$type];
 250+ return isset( $types[$type] ) ? $types[$type] : $types['other'];
251251 }
252252
253253 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r797201.17: MFT r79578, r79591, r79593, r79595, r79649, r79650, r79651, r79653, r79...catrope14:48, 6 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71071Added function to get extension type messagesjeroendedauw14:04, 14 August 2010

Status & tagging log