r79283 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79282‎ | r79283 | r79284 >
Date:18:53, 30 December 2010
Author:greg
Status:ok
Tags:
Comment:
Don't put multiple tables in the same file.
Modified paths:
  • /trunk/phase3/includes/installer/PostgresUpdater.php (modified) (history)
  • /trunk/phase3/maintenance/postgres/archives/patch-change_tag.sql (modified) (history)
  • /trunk/phase3/maintenance/postgres/archives/patch-tag_summary.sql (added) (history)
  • /trunk/phase3/maintenance/postgres/archives/patch-valid_tag.sql (added) (history)

Diff [purge]

Index: trunk/phase3/maintenance/postgres/archives/patch-tag_summary.sql
@@ -0,0 +1,9 @@
 2+CREATE TABLE tag_summary (
 3+ ts_rc_id INTEGER NULL,
 4+ ts_log_id INTEGER NULL,
 5+ ts_rev_id INTEGER NULL,
 6+ ts_tags TEXT NOT NULL
 7+);
 8+CREATE UNIQUE INDEX tag_summary_rc_id ON tag_summary(ts_rc_id);
 9+CREATE UNIQUE INDEX tag_summary_log_id ON tag_summary(ts_log_id);
 10+CREATE UNIQUE INDEX tag_summary_rev_id ON tag_summary(ts_rev_id);
Index: trunk/phase3/maintenance/postgres/archives/patch-valid_tag.sql
@@ -0,0 +1,3 @@
 2+CREATE TABLE valid_tag (
 3+ vt_tag TEXT NOT NULL PRIMARY KEY
 4+);
Index: trunk/phase3/maintenance/postgres/archives/patch-change_tag.sql
@@ -1,28 +1,11 @@
2 -
32 CREATE TABLE change_tag (
4 - ct_rc_id INTEGER NULL,
5 - ct_log_id INTEGER NULL,
6 - ct_rev_id INTEGER NULL,
7 - ct_tag TEXT NOT NULL,
8 - ct_params TEXT NULL
 3+ ct_rc_id INTEGER NULL,
 4+ ct_log_id INTEGER NULL,
 5+ ct_rev_id INTEGER NULL,
 6+ ct_tag TEXT NOT NULL,
 7+ ct_params TEXT NULL
98 );
109 CREATE UNIQUE INDEX change_tag_rc_tag ON change_tag(ct_rc_id,ct_tag);
1110 CREATE UNIQUE INDEX change_tag_log_tag ON change_tag(ct_log_id,ct_tag);
1211 CREATE UNIQUE INDEX change_tag_rev_tag ON change_tag(ct_rev_id,ct_tag);
1312 CREATE INDEX change_tag_tag_id ON change_tag(ct_tag,ct_rc_id,ct_rev_id,ct_log_id);
14 -
15 -
16 -CREATE TABLE tag_summary (
17 - ts_rc_id INTEGER NULL,
18 - ts_log_id INTEGER NULL,
19 - ts_rev_id INTEGER NULL,
20 - ts_tags TEXT NOT NULL
21 -);
22 -CREATE UNIQUE INDEX tag_summary_rc_id ON tag_summary(ts_rc_id);
23 -CREATE UNIQUE INDEX tag_summary_log_id ON tag_summary(ts_log_id);
24 -CREATE UNIQUE INDEX tag_summary_rev_id ON tag_summary(ts_rev_id);
25 -
26 -
27 -CREATE TABLE valid_tag (
28 - vt_tag TEXT NOT NULL PRIMARY KEY
29 -);
Index: trunk/phase3/includes/installer/PostgresUpdater.php
@@ -48,8 +48,8 @@
4949 array( 'addTable', 'redirect', 'patch-redirect.sql' ),
5050 array( 'addTable', 'updatelog', 'patch-updatelog.sql' ),
5151 array( 'addTable', 'change_tag', 'patch-change_tag.sql' ),
52 - array( 'addTable', 'tag_summary', 'patch-change_tag.sql' ),
53 - array( 'addTable', 'valid_tag', 'patch-change_tag.sql' ),
 52+ array( 'addTable', 'tag_summary', 'patch-tag_summary.sql' ),
 53+ array( 'addTable', 'valid_tag', 'patch-valid_tag.sql' ),
5454 array( 'addTable', 'user_properties', 'patch-user_properties.sql' ),
5555 array( 'addTable', 'log_search', 'patch-log_search.sql' ),
5656 array( 'addTable', 'l10n_cache', 'patch-l10n_cache.sql' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r79284Followup r79283, svn:eol-style nativereedy18:56, 30 December 2010
r801901.17: MFT first batch of installer changes: r78043, r78231, r78259, r78300, r...catrope20:47, 13 January 2011

Status & tagging log