r79225 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79224‎ | r79225 | r79226 >
Date:02:05, 30 December 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r70572, seems n isn't defined on all code paths. Explicitally define as 0

Remove unused local variable
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage_body.php
@@ -1327,7 +1327,6 @@
13281328 */
13291329 function update_pr_index( $index, $deletedpage = null ) {
13301330 $page_namespace = $this->page_namespace;
1331 - $index_namespace = $this->index_namespace;
13321331 $page_ns_index = MWNamespace::getCanonicalIndex( strtolower( $page_namespace ) );
13331332 if ( $page_ns_index == null ) {
13341333 return;
@@ -1337,6 +1336,8 @@
13381337 $index_id = $index->getID();
13391338 $dbr = wfGetDB( DB_SLAVE );
13401339
 1340+ $n = 0;
 1341+
13411342 // read the list of pages
13421343 $pages = array();
13431344 list( $links, $params, $attributes ) = $this->parse_index( $index_title );

Follow-up revisions

RevisionCommit summaryAuthorDate
r79260Followup r79225, fix spaces to tabreedy16:34, 30 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70572return early if the list of page links is emptythomasv15:07, 6 August 2010

Comments

#Comment by Platonides (talk | contribs)   15:41, 30 December 2010

Spaces instead of tabs

Status & tagging log