r70572 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70571‎ | r70572 | r70573 >
Date:15:07, 6 August 2010
Author:thomasv
Status:resolved
Tags:
Comment:
return early if the list of page links is empty
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage.php
@@ -1259,6 +1259,10 @@
12601260 }
12611261 }
12621262
 1263+ if( $n==0 ) {
 1264+ return;
 1265+ }
 1266+
12631267 $catlinks = $dbr->tableName( 'categorylinks' );
12641268 $page = $dbr->tableName( 'page' );
12651269 $pagelist = "'".implode( "', '", $pages)."'";

Follow-up revisions

RevisionCommit summaryAuthorDate
r79225Followup r70572, seems n isn't defined on all code paths. Explicitally define...reedy02:05, 30 December 2010

Status & tagging log