r78996 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r78995‎ | r78996 | r78997 >
Date:12:30, 25 December 2010
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Rm useless checks which breaks if descriptionmsg is an array
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
——@@ -418,13 +418,10 @@
419419 $descriptionMsgKey = $descriptionMsg[0]; // Get the message key
420420 array_shift( $descriptionMsg ); // Shift out the message key to get the parameters only
421421 array_map( "htmlspecialchars", $descriptionMsg ); // For sanity
422 - $msg = wfMsg( $descriptionMsgKey, $descriptionMsg );
 422+ $description = wfMsg( $descriptionMsgKey, $descriptionMsg );
423423 } else {
424 - $msg = wfMsg( $descriptionMsg );
 424+ $description = wfMsg( $descriptionMsg );
425425 }
426 - if ( !wfEmptyMsg( $descriptionMsg, $msg ) && $msg != '' ) {
427 - $description = $msg;
428 - }
429426 }
430427
431428 if ( $svnText !== false ) {

Comments

#Comment by Bawolff (talk | contribs)   20:46, 10 June 2011

I'm adding the tag 1.17 to this since according to bug 29334 this fixes a regression in 1.17 with special:version breaking when descriptionmsg is an array. (I have no idea what the status of 1.17 is, and if its too late for a fix to such a minor issue).

#Comment by Tim Starling (talk | contribs)   22:43, 10 June 2011

Is there some user-visible consequence of this? Was it a regression? Is there some extension that hits it?

#Comment by Bawolff (talk | contribs)   23:09, 10 June 2011

A quick grep suggests that extension:Lingo is the only one in Wikimedia's repository that would currently, but semantic maps did until quite recently (r83905). Presumably the reporter of bug 29334 has an extension that hits it in order to report the bug.

#Comment by RobLa-WMF (talk | contribs)   01:13, 14 June 2011

This needs release notes, and is a little late to merge in at this point. We'll consider a 1.17.1 if this is a bigger problem than we anticipate, but let's not hold up the release over this.

Status & tagging log