r83905 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83904‎ | r83905 | r83906 >
Date:15:33, 14 March 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
simply extension description
Modified paths:
  • /branches/SemanticMaps0.8/SemanticMaps.i18n.php (modified) (history)
  • /branches/SemanticMaps0.8/SemanticMaps.php (modified) (history)

Diff [purge]

Index: branches/SemanticMaps0.8/SemanticMaps.i18n.php
@@ -16,10 +16,7 @@
1717 */
1818 $messages['en'] = array(
1919 // General
20 - 'semanticmaps_name' => 'Semantic Maps',
21 - // TODO: update demo link to the new wiki, once it has 0.6.x running.
22 - 'semanticmaps_desc' => "Provides the ability to view and edit coordinate data stored through the Semantic MediaWiki extension ([http://mapping.referata.com/wiki/Semantic_Maps_examples demo's]).
23 -Available mapping services: $1",
 20+ 'semanticmaps-desc' => "Provides the ability to view and edit coordinate data stored with the Semantic MediaWiki extension ([http://mapping.referata.com/wiki/Examples demo's]).",
2421 'semanticmaps-unrecognizeddistance' => 'The value $1 is not a valid distance.',
2522 'semanticmaps-kml-link' => 'View the KML file',
2623 'semanticmaps-kml' => 'KML',
Index: branches/SemanticMaps0.8/SemanticMaps.php
@@ -43,6 +43,17 @@
4444
4545 define( 'SM_VERSION', '0.8 alpha' );
4646
 47+$wgExtensionCredits[defined( 'SEMANTIC_EXTENSION_TYPE' ) ? 'semantic' : 'other'][] = array(
 48+ 'path' => __FILE__,
 49+ 'name' => 'Semantic Maps',
 50+ 'version' => SM_VERSION,
 51+ 'author' => array(
 52+ '[http://www.mediawiki.org/wiki/User:Jeroen_De_Dauw Jeroen De Dauw]'
 53+ ),
 54+ 'url' => 'http://www.mediawiki.org/wiki/Extension:Semantic_Maps',
 55+ 'descriptionmsg' => 'semanticmaps-desc'
 56+);
 57+
4758 $smgScriptPath = ( $wgExtensionAssetsPath === false ? '/extensions' : $wgExtensionAssetsPath ) . '/SemanticMaps';
4859 $smgDir = dirname( __FILE__ ) . '/';
4960
@@ -71,8 +82,6 @@
7283 # Yahoo! Maps API
7384 include_once $smgDir . 'includes/services/YahooMaps/SM_YahooMaps.php';
7485
75 -$wgExtensionFunctions[] = 'smfSetup';
76 -
7786 $wgExtensionMessagesFiles['SemanticMaps'] = $smgDir . 'SemanticMaps.i18n.php';
7887
7988 $incDir = dirname( __FILE__ ) . '/includes/';
@@ -100,34 +109,3 @@
101110
102111 // Hook for adding a Semantic Maps links to the Admin Links extension.
103112 $wgHooks['AdminLinks'][] = 'SemanticMapsHooks::addToAdminLinks';
104 -
105 -/**
106 - * 'Initialization' function for the Semantic Maps extension.
107 - * The only work done here is creating the extension credits for
108 - * Semantic Maps. The actuall work in done via the Maps hooks.
109 - *
110 - * @since 0.1
111 - *
112 - * @return true
113 - */
114 -function smfSetup() {
115 - global $wgExtensionCredits, $wgLang;
116 -
117 - // Creation of a list of internationalized service names.
118 - $services = array();
119 - foreach ( MapsMappingServices::getServiceIdentifiers() as $identifier ) $services[] = wfMsg( 'maps_' . $identifier );
120 - $servicesList = $wgLang->listToText( $services );
121 -
122 - $wgExtensionCredits[defined( 'SEMANTIC_EXTENSION_TYPE' ) ? 'semantic' : 'other'][] = array(
123 - 'path' => __FILE__,
124 - 'name' => wfMsg( 'semanticmaps_name' ),
125 - 'version' => SM_VERSION,
126 - 'author' => array(
127 - '[http://www.mediawiki.org/wiki/User:Jeroen_De_Dauw Jeroen De Dauw]'
128 - ),
129 - 'url' => 'http://www.mediawiki.org/wiki/Extension:Semantic_Maps',
130 - 'description' => wfMsgExt( 'semanticmaps_desc', 'parsemag', $servicesList ),
131 - );
132 -
133 - return true;
134 -}

Follow-up revisions

RevisionCommit summaryAuthorDate
r83906follow up to r83905jeroendedauw15:34, 14 March 2011

Status & tagging log