r78895 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78894‎ | r78895 | r78896 >
Date:17:37, 23 December 2010
Author:reedy
Status:deferred
Tags:
Comment:
Change $this (you're in a static method!) to $domain
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaHost.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaHost.php
@@ -156,7 +156,7 @@
157157 return false;
158158 }
159159 $host = OpenStackNovaHost::getLDAPArray( $hostname, $ip, $domainname );
160 - $dn = 'dc=' . $hostname . ',dc=' . $this->getDomainName() . ',' . $wgOpenStackManagerLDAPDNSDomainBaseDN;
 160+ $dn = 'dc=' . $hostname . ',dc=' . $domain->getDomainName() . ',' . $wgOpenStackManagerLDAPDNSDomainBaseDN;
161161
162162 $success = @ldap_add( $wgAuth->ldapconn, $dn, $host );
163163 if ( $success ) {

Status & tagging log