r78823 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78822‎ | r78823 | r78824 >
Date:20:33, 22 December 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Comment out unreachable code line
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -218,7 +218,7 @@
219219 $this->endForm( 'continue' );
220220 return 'output';
221221 }
222 - return $this->handleExistingUpgrade( $vars );
 222+ //return $this->handleExistingUpgrade( $vars );
223223 }
224224
225225 // If there is no $wgUpgradeKey, tell the user to add one to LocalSettings.php

Follow-up revisions

RevisionCommit summaryAuthorDate
r79191Followup r78823: just remove the offending line entirelydemon17:15, 29 December 2010
r801901.17: MFT first batch of installer changes: r78043, r78231, r78259, r78300, r...catrope20:47, 13 January 2011

Comments

#Comment by Platonides (talk | contribs)   21:49, 22 December 2010

I'd at comment it as

+ //Unreachable return $this->handleExistingUpgrade( $vars );

Status & tagging log