r78795 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78794‎ | r78795 | r78796 >
Date:15:20, 22 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Followup r78786, fix special wanted pages. Aliasing pages in left join doesn't work

Trim some trailing whitespace too
Modified paths:
  • /trunk/phase3/includes/specials/SpecialWantedpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWantedpages.php
@@ -30,7 +30,7 @@
3131 function __construct( $name = 'Wantedpages' ) {
3232 parent::__construct( $name );
3333 }
34 -
 34+
3535 function execute( $par ) {
3636 $inc = $this->including();
3737
@@ -64,16 +64,16 @@
6565 NS_MEDIAWIKI . "'" ),
6666 'options' => array ( 'HAVING' => "COUNT(*) > $count",
6767 'GROUP BY' => 'pl_namespace, pl_title' ),
68 - 'join_conds' => array ( 'page AS pg1' => array (
 68+ 'join_conds' => array ( 'pg1' => array (
6969 'LEFT JOIN', array (
7070 'pg1.page_namespace = pl_namespace',
7171 'pg1.page_title = pl_title' ) ),
72 - 'page AS pg2' => array ( 'LEFT JOIN',
 72+ 'pg2' => array ( 'LEFT JOIN',
7373 'pg2.page_id = pl_from' ) )
7474 );
7575 // Replacement WantedPages::getSQL
7676 wfRunHooks( 'WantedPages::getQueryInfo',
7777 array( &$this, &$query ) );
7878 return $query;
79 - }
 79+ }
8080 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78786Merge querypage-work2 branch from trunk. The most relevant changes are:...catrope14:16, 22 December 2010

Status & tagging log