r78796 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78795‎ | r78796 | r78797 >
Date:15:22, 22 December 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Few @since annotations
Modified paths:
  • /trunk/phase3/includes/QueryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/QueryPage.php
@@ -159,6 +159,7 @@
160160 * or TS_UNIX (querycache) format, so be sure to always run them
161161 * through wfTimestamp()
162162 * @return bool
 163+ * @since 1.18
163164 */
164165 function usesTimestamps() {
165166 return false;
@@ -190,6 +191,7 @@
191192 * will be disabled in miser mode and will not have their results written
192193 * to the querycache table.
193194 * @return Boolean
 195+ * @since 1.18
194196 */
195197 public function isCacheable() {
196198 return true;
@@ -332,6 +334,7 @@
333335 * @param $limit mixed Numerical limit or false for no limit
334336 * @param $offset mixed Numerical offset or false for no offset
335337 * @return ResultWrapper
 338+ * @since 1.18
336339 */
337340 function reallyDoQuery( $limit, $offset = false ) {
338341 $fname = get_class( $this ) . "::reallyDoQuery";
@@ -372,6 +375,9 @@
373376 return $dbr->resultObject( $res );
374377 }
375378
 379+ /**
 380+ * Parameters and order changed in 1.18
 381+ */
376382 function doQuery( $limit, $offset = false ) {
377383 if ( $this->isCached() && $this->isCacheable() ) {
378384 return $this->fetchFromCache( $limit, $offset );
@@ -385,6 +391,7 @@
386392 * @param $limit mixed Numerical limit or false for no limit
387393 * @param $offset mixed Numerical offset or false for no offset
388394 * @return ResultWrapper
 395+ * @since 1.18
389396 */
390397 function fetchFromCache( $limit, $offset = false ) {
391398 $dbr = wfGetDB( DB_SLAVE );

Status & tagging log