r78695 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78694‎ | r78695 | r78696 >
Date:17:15, 21 December 2010
Author:catrope
Status:resolved
Tags:
Comment:
Followup r78192: rather than silently ignoring calls to undefined SpecialPage methods, throw an exception
Modified paths:
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPage.php
@@ -748,6 +748,8 @@
749749 $file = isset( $a[4] ) ? $a[4] : 'default';
750750 $includable = isset( $a[5] ) ? $a[5] : false;
751751 $this->init( $name, $restriction, $listed, $function, $file, $includable );
 752+ } else {
 753+ throw new MWException( "Call to undefined method SpecialPage::$fName" );
752754 }
753755 }
754756

Follow-up revisions

RevisionCommit summaryAuthorDate
r78697Follow-up r78695: correct class nameialex17:41, 21 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78192Fix for r71961 (moved SpecialPage constructor from named to __construct()). I...demon15:15, 10 December 2010

Status & tagging log