r71961 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r71960‎ | r71961 | r71962 >
Date:16:52, 30 August 2010
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Get rid of PHP4-style constructors
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/Exif.php (modified) (history)
  • /trunk/phase3/includes/Export.php (modified) (history)
  • /trunk/phase3/includes/HistoryBlob.php (modified) (history)
  • /trunk/phase3/includes/Licenses.php (modified) (history)
  • /trunk/phase3/includes/LinksUpdate.php (modified) (history)
  • /trunk/phase3/includes/Revision.php (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/includes/WikiError.php (modified) (history)
  • /trunk/phase3/includes/ZhClient.php (modified) (history)
  • /trunk/phase3/includes/db/Database.php (modified) (history)
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)
  • /trunk/phase3/includes/filerepo/ArchivedFile.php (modified) (history)
  • /trunk/phase3/includes/json/Services_JSON.php (modified) (history)
  • /trunk/phase3/includes/media/MediaTransformOutput.php (modified) (history)
  • /trunk/phase3/includes/parser/DateFormatter.php (modified) (history)
  • /trunk/phase3/includes/parser/ParserOutput.php (modified) (history)
  • /trunk/phase3/includes/search/SearchEngine.php (modified) (history)
  • /trunk/phase3/includes/search/SearchMySQL.php (modified) (history)
  • /trunk/phase3/includes/search/SearchSqlite.php (modified) (history)
  • /trunk/phase3/includes/search/SearchUpdate.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialFileDuplicateSearch.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMIMEsearch.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUncategorizedcategories.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialWantedpages.php (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)
  • /trunk/phase3/maintenance/importDump.php (modified) (history)
  • /trunk/phase3/maintenance/rebuildImages.php (modified) (history)
  • /trunk/phase3/profileinfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/rebuildImages.php
——@@ -36,7 +36,7 @@
3737 require_once( 'FiveUpgrade.inc' );
3838
3939 class ImageBuilder extends FiveUpgrade {
40 - function ImageBuilder( $dryrun = false ) {
 40+ function __construct( $dryrun = false ) {
4141 parent::FiveUpgrade();
4242
4343 $this->maxLag = 10; # if slaves are lagged more than 10 secs, wait
Index: trunk/phase3/maintenance/importDump.php
——@@ -38,7 +38,7 @@
3939 var $debug = false;
4040 var $uploads = false;
4141
42 - function BackupReader() {
 42+ function __construct() {
4343 $this->stderr = fopen( "php://stderr", "wt" );
4444 }
4545
Index: trunk/phase3/includes/ZhClient.php
——@@ -12,7 +12,7 @@
1313 *
1414 * @access private
1515 */
16 - function ZhClient($host, $port) {
 16+ function __construct($host, $port) {
1717 $this->mHost = $host;
1818 $this->mPort = $port;
1919 $this->mConnected = $this->connect();
Index: trunk/phase3/includes/EditPage.php
——@@ -96,7 +96,7 @@
9797 * @todo document
9898 * @param $article
9999 */
100 - function EditPage( $article ) {
 100+ function __construct( $article ) {
101101 $this->mArticle =& $article;
102102 $this->mTitle = $article->getTitle();
103103 $this->action = 'submit';
Index: trunk/phase3/includes/Revision.php
——@@ -290,7 +290,7 @@
291291 * @param $row Mixed: either a database row or an array
292292 * @access private
293293 */
294 - function Revision( $row ) {
 294+ function __construct( $row ) {
295295 if( is_object( $row ) ) {
296296 $this->mId = intval( $row->rev_id );
297297 $this->mPage = intval( $row->rev_page );
Index: trunk/phase3/includes/db/DatabasePostgres.php
——@@ -96,7 +96,7 @@
9797 var $numeric_version = null;
9898 var $mAffectedRows = null;
9999
100 - function DatabasePostgres($server = false, $user = false, $password = false, $dbName = false,
 100+ function __construct($server = false, $user = false, $password = false, $dbName = false,
101101 $failFunction = false, $flags = 0 )
102102 {
103103
Index: trunk/phase3/includes/db/Database.php
——@@ -2278,7 +2278,7 @@
22792279 class DBObject {
22802280 public $mData;
22812281
2282 - function DBObject($data) {
 2282+ function __construct($data) {
22832283 $this->mData = $data;
22842284 }
22852285
——@@ -2635,7 +2635,7 @@
26362636 /**
26372637 * Create a new result object from a result resource and a Database object
26382638 */
2639 - function ResultWrapper( $database, $result ) {
 2639+ function __construct( $database, $result ) {
26402640 $this->db = $database;
26412641 if ( $result instanceof ResultWrapper ) {
26422642 $this->result = $result->result;
Index: trunk/phase3/includes/User.php
——@@ -178,7 +178,7 @@
179179 * @see newFromSession()
180180 * @see newFromRow()
181181 */
182 - function User() {
 182+ function __construct() {
183183 $this->clearInstanceCache( 'defaults' );
184184 }
185185
Index: trunk/phase3/includes/Export.php
——@@ -663,7 +663,7 @@
664664 class DumpFileOutput extends DumpOutput {
665665 var $handle;
666666
667 - function DumpFileOutput( $file ) {
 667+ function __construct( $file ) {
668668 $this->handle = fopen( $file, "wt" );
669669 }
670670
——@@ -679,7 +679,7 @@
680680 * @ingroup Dump
681681 */
682682 class DumpPipeOutput extends DumpFileOutput {
683 - function DumpPipeOutput( $command, $file = null ) {
 683+ function __construct( $command, $file = null ) {
684684 if( !is_null( $file ) ) {
685685 $command .= " > " . wfEscapeShellArg( $file );
686686 }
——@@ -692,8 +692,8 @@
693693 * @ingroup Dump
694694 */
695695 class DumpGZipOutput extends DumpPipeOutput {
696 - function DumpGZipOutput( $file ) {
697 - parent::DumpPipeOutput( "gzip", $file );
 696+ function __construct( $file ) {
 697+ parent::__construct( "gzip", $file );
698698 }
699699 }
700700
——@@ -702,8 +702,8 @@
703703 * @ingroup Dump
704704 */
705705 class DumpBZip2Output extends DumpPipeOutput {
706 - function DumpBZip2Output( $file ) {
707 - parent::DumpPipeOutput( "bzip2", $file );
 706+ function __construct( $file ) {
 707+ parent::__construct( "bzip2", $file );
708708 }
709709 }
710710
——@@ -712,12 +712,12 @@
713713 * @ingroup Dump
714714 */
715715 class Dump7ZipOutput extends DumpPipeOutput {
716 - function Dump7ZipOutput( $file ) {
 716+ function __construct( $file ) {
717717 $command = "7za a -bd -si " . wfEscapeShellArg( $file );
718718 // Suppress annoying useless crap from p7zip
719719 // Unfortunately this could suppress real error messages too
720720 $command .= ' >' . wfGetNull() . ' 2>&1';
721 - parent::DumpPipeOutput( $command );
 721+ parent::__construct( $command );
722722 }
723723 }
724724
——@@ -730,7 +730,7 @@
731731 * @ingroup Dump
732732 */
733733 class DumpFilter {
734 - function DumpFilter( &$sink ) {
 734+ function __construct( &$sink ) {
735735 $this->sink =& $sink;
736736 }
737737
——@@ -793,8 +793,8 @@
794794 var $invert = false;
795795 var $namespaces = array();
796796
797 - function DumpNamespaceFilter( &$sink, $param ) {
798 - parent::DumpFilter( $sink );
 797+ function __construct( &$sink, $param ) {
 798+ parent::__construct( $sink );
799799
800800 $constants = array(
801801 "NS_MAIN" => NS_MAIN,
——@@ -879,7 +879,7 @@
880880 * @ingroup Dump
881881 */
882882 class DumpMultiWriter {
883 - function DumpMultiWriter( $sinks ) {
 883+ function __construct( $sinks ) {
884884 $this->sinks = $sinks;
885885 $this->count = count( $sinks );
886886 }
Index: trunk/phase3/includes/LinksUpdate.php
——@@ -30,7 +30,7 @@
3131 * @param $parserOutput ParserOutput: output from a full parse of this page
3232 * @param $recursive Boolean: queue jobs for recursive updates?
3333 */
34 - function LinksUpdate( $title, $parserOutput, $recursive = true ) {
 34+ function __construct( $title, $parserOutput, $recursive = true ) {
3535 global $wgAntiLockFlags;
3636
3737 if ( $wgAntiLockFlags & ALF_NO_LINK_LOCK ) {
Index: trunk/phase3/includes/Exif.php
——@@ -620,7 +620,7 @@
621621 * @param $exif Array: the Exif data to format ( as returned by
622622 * Exif::getFilteredData() )
623623 */
624 - function FormatExif( $exif ) {
 624+ function __construct( $exif ) {
625625 $this->mExif = $exif;
626626 }
627627
Index: trunk/phase3/includes/filerepo/ArchivedFile.php
——@@ -29,7 +29,7 @@
3030
3131 /**#@-*/
3232
33 - function ArchivedFile( $title, $id=0, $key='' ) {
 33+ function __construct( $title, $id=0, $key='' ) {
3434 $this->id = -1;
3535 $this->title = false;
3636 $this->name = false;
Index: trunk/phase3/includes/search/SearchEngine.php
——@@ -847,7 +847,7 @@
848848 class SearchHighlighter {
849849 var $mCleanWikitext = true;
850850
851 - function SearchHighlighter( $cleanupWikitext = true ) {
 851+ function __construct( $cleanupWikitext = true ) {
852852 $this->mCleanWikitext = $cleanupWikitext;
853853 }
854854
Index: trunk/phase3/includes/search/SearchMySQL.php
——@@ -402,7 +402,7 @@
403403 * @ingroup Search
404404 */
405405 class MySQLSearchResultSet extends SqlSearchResultSet {
406 - function MySQLSearchResultSet( $resultSet, $terms, $totalHits=null ) {
 406+ function __construct( $resultSet, $terms, $totalHits=null ) {
407407 parent::__construct( $resultSet, $terms );
408408 $this->mTotalHits = $totalHits;
409409 }
Index: trunk/phase3/includes/search/SearchSqlite.php
——@@ -323,7 +323,7 @@
324324 * @ingroup Search
325325 */
326326 class SqliteSearchResultSet extends SqlSearchResultSet {
327 - function SqliteSearchResultSet( $resultSet, $terms, $totalHits=null ) {
 327+ function __construct( $resultSet, $terms, $totalHits=null ) {
328328 parent::__construct( $resultSet, $terms );
329329 $this->mTotalHits = $totalHits;
330330 }
Index: trunk/phase3/includes/search/SearchUpdate.php
——@@ -18,7 +18,7 @@
1919 /* private */ var $mId = 0, $mNamespace, $mTitle, $mText;
2020 /* private */ var $mTitleWords;
2121
22 - function SearchUpdate( $id, $title, $text = false ) {
 22+ function __construct( $id, $title, $text = false ) {
2323 $nt = Title::newFromText( $title );
2424 if( $nt ) {
2525 $this->mId = $id;
Index: trunk/phase3/includes/media/MediaTransformOutput.php
——@@ -115,7 +115,7 @@
116116 * @param $page Integer: page number, for multipage files
117117 * @private
118118 */
119 - function ThumbnailImage( $file, $url, $width, $height, $path = false, $page = false ) {
 119+ function __construct( $file, $url, $width, $height, $path = false, $page = false ) {
120120 $this->file = $file;
121121 $this->url = $url;
122122 # These should be integers when they get here.
Index: trunk/phase3/includes/parser/ParserOutput.php
——@@ -123,7 +123,7 @@
124124 $mTOCHTML = ''; # HTML of the TOC
125125 private $mIndexPolicy = ''; # 'index' or 'noindex'? Any other value will result in no change.
126126
127 - function ParserOutput( $text = '', $languageLinks = array(), $categoryLinks = array(),
 127+ function __construct( $text = '', $languageLinks = array(), $categoryLinks = array(),
128128 $containsOldMagic = false, $titletext = '' )
129129 {
130130 $this->mText = $text;
Index: trunk/phase3/includes/parser/DateFormatter.php
——@@ -34,7 +34,7 @@
3535 /**
3636 * @todo document
3737 */
38 - function DateFormatter() {
 38+ function __construct() {
3939 global $wgContLang;
4040
4141 $this->monthNames = $this->getMonthRegex();
Index: trunk/phase3/includes/SpecialPage.php
——@@ -703,7 +703,7 @@
704704 * @param $file String: file which is included by execute(). It is also constructed from $name by default
705705 * @param $includable Boolean: whether the page can be included in normal pages
706706 */
707 - function SpecialPage( $name = '', $restriction = '', $listed = true, $function = false, $file = 'default', $includable = false ) {
 707+ function __construct( $name = '', $restriction = '', $listed = true, $function = false, $file = 'default', $includable = false ) {
708708 $this->mName = $name;
709709 $this->mRestriction = $restriction;
710710 $this->mListed = $listed;
——@@ -914,8 +914,8 @@
915915 */
916916 class UnlistedSpecialPage extends SpecialPage
917917 {
918 - function UnlistedSpecialPage( $name, $restriction = '', $function = false, $file = 'default' ) {
919 - parent::SpecialPage( $name, $restriction, false, $function, $file );
 918+ function __construct( $name, $restriction = '', $function = false, $file = 'default' ) {
 919+ parent::__construct( $name, $restriction, false, $function, $file );
920920 }
921921 }
922922
——@@ -925,8 +925,8 @@
926926 */
927927 class IncludableSpecialPage extends SpecialPage
928928 {
929 - function IncludableSpecialPage( $name, $restriction = '', $listed = true, $function = false, $file = 'default' ) {
930 - parent::SpecialPage( $name, $restriction, $listed, $function, $file, true );
 929+ function __construct( $name, $restriction = '', $listed = true, $function = false, $file = 'default' ) {
 930+ parent::__construct( $name, $restriction, $listed, $function, $file, true );
931931 }
932932 }
933933
Index: trunk/phase3/includes/HistoryBlob.php
——@@ -157,7 +157,7 @@
158158 * @param $hash Strng: the content hash of the text
159159 * @param $oldid Integer: the old_id for the CGZ object
160160 */
161 - function HistoryBlobStub( $hash = '', $oldid = 0 ) {
 161+ function __construct( $hash = '', $oldid = 0 ) {
162162 $this->mHash = $hash;
163163 }
164164
——@@ -253,7 +253,7 @@
254254 /**
255255 * @param $curid Integer: the cur_id pointed to
256256 */
257 - function HistoryBlobCurStub( $curid = 0 ) {
 257+ function __construct( $curid = 0 ) {
258258 $this->mCurId = $curid;
259259 }
260260
Index: trunk/phase3/includes/WikiError.php
——@@ -73,7 +73,7 @@
7474 * @param $message String: wiki message name
7575 * @param ... parameters to pass to wfMsg()
7676 */
77 - function WikiErrorMsg( $message/*, ... */ ) {
 77+ function __construct( $message/*, ... */ ) {
7878 $args = func_get_args();
7979 array_shift( $args );
8080 $this->mMessage = wfMsgReal( $message, $args, true );
——@@ -102,7 +102,7 @@
103103 * @param $context
104104 * @param $offset Int
105105 */
106 - function WikiXmlError( $parser, $message = 'XML parsing error', $context = null, $offset = 0 ) {
 106+ function __construct( $parser, $message = 'XML parsing error', $context = null, $offset = 0 ) {
107107 $this->mXmlError = xml_get_error_code( $parser );
108108 $this->mColumn = xml_get_current_column_number( $parser );
109109 $this->mLine = xml_get_current_line_number( $parser );
Index: trunk/phase3/includes/diff/DifferenceEngine.php
——@@ -41,7 +41,7 @@
4242 class _DiffOp_Copy extends _DiffOp {
4343 var $type = 'copy';
4444
45 - function _DiffOp_Copy ($orig, $closing = false) {
 45+ function __construct ($orig, $closing = false) {
4646 if (!is_array($closing))
4747 $closing = $orig;
4848 $this->orig = $orig;
——@@ -61,7 +61,7 @@
6262 class _DiffOp_Delete extends _DiffOp {
6363 var $type = 'delete';
6464
65 - function _DiffOp_Delete ($lines) {
 65+ function __construct ($lines) {
6666 $this->orig = $lines;
6767 $this->closing = false;
6868 }
——@@ -79,7 +79,7 @@
8080 class _DiffOp_Add extends _DiffOp {
8181 var $type = 'add';
8282
83 - function _DiffOp_Add ($lines) {
 83+ function __construct ($lines) {
8484 $this->closing = $lines;
8585 $this->orig = false;
8686 }
——@@ -97,7 +97,7 @@
9898 class _DiffOp_Change extends _DiffOp {
9999 var $type = 'change';
100100
101 - function _DiffOp_Change ($orig, $closing) {
 101+ function __construct ($orig, $closing) {
102102 $this->orig = $orig;
103103 $this->closing = $closing;
104104 }
——@@ -568,7 +568,7 @@
569569 * (Typically these are lines from a file.)
570570 * @param $to_lines array An array of strings.
571571 */
572 - function Diff($from_lines, $to_lines) {
 572+ function __construct($from_lines, $to_lines) {
573573 $eng = new _DiffEngine;
574574 $this->edits = $eng->diff($from_lines, $to_lines);
575575 //$this->_check($from_lines, $to_lines);
——@@ -720,14 +720,14 @@
721721 * @param $mapped_to_lines array This array should
722722 * have the same number of elements as $to_lines.
723723 */
724 - function MappedDiff($from_lines, $to_lines,
 724+ function __construct($from_lines, $to_lines,
725725 $mapped_from_lines, $mapped_to_lines) {
726726 wfProfileIn( __METHOD__ );
727727
728728 assert(sizeof($from_lines) == sizeof($mapped_from_lines));
729729 assert(sizeof($to_lines) == sizeof($mapped_to_lines));
730730
731 - $this->Diff($mapped_from_lines, $mapped_to_lines);
 731+ parent::__construct($mapped_from_lines, $mapped_to_lines);
732732
733733 $xi = $yi = 0;
734734 for ($i = 0; $i < sizeof($this->edits); $i++) {
——@@ -992,7 +992,7 @@
993993 * @ingroup DifferenceEngine
994994 */
995995 class _HWLDF_WordAccumulator {
996 - function _HWLDF_WordAccumulator () {
 996+ function __construct () {
997997 $this->_lines = array();
998998 $this->_line = '';
999999 $this->_group = '';
——@@ -1055,13 +1055,13 @@
10561056 class WordLevelDiff extends MappedDiff {
10571057 const MAX_LINE_LENGTH = 10000;
10581058
1059 - function WordLevelDiff ($orig_lines, $closing_lines) {
 1059+ function __construct ($orig_lines, $closing_lines) {
10601060 wfProfileIn( __METHOD__ );
10611061
10621062 list ($orig_words, $orig_stripped) = $this->_split($orig_lines);
10631063 list ($closing_words, $closing_stripped) = $this->_split($closing_lines);
10641064
1065 - $this->MappedDiff($orig_words, $closing_words,
 1065+ parent::__construct($orig_words, $closing_words,
10661066 $orig_stripped, $closing_stripped);
10671067 wfProfileOut( __METHOD__ );
10681068 }
——@@ -1136,7 +1136,7 @@
11371137 * @ingroup DifferenceEngine
11381138 */
11391139 class TableDiffFormatter extends DiffFormatter {
1140 - function TableDiffFormatter() {
 1140+ function __construct() {
11411141 $this->leading_context_lines = 2;
11421142 $this->trailing_context_lines = 2;
11431143 }
Index: trunk/phase3/includes/json/Services_JSON.php
——@@ -132,7 +132,7 @@
133133 * bubble up with an error, so all return values
134134 * from encode() should be checked with isError()
135135 */
136 - function Services_JSON($use = 0)
 136+ function __construct($use = 0)
137137 {
138138 $this->use = $use;
139139 }
Index: trunk/phase3/includes/Licenses.php
——@@ -166,7 +166,7 @@
167167 *
168168 * @param $str String: license name??
169169 */
170 - function License( $str ) {
 170+ function __construct( $str ) {
171171 list( $text, $template ) = explode( '|', strrev( $str ), 2 );
172172
173173 $this->template = strrev( $template );
Index: trunk/phase3/includes/specials/SpecialFileDuplicateSearch.php
——@@ -31,7 +31,7 @@
3232 class FileDuplicateSearchPage extends QueryPage {
3333 var $hash, $filename;
3434
35 - function FileDuplicateSearchPage( $hash, $filename ) {
 35+ function __construct( $hash, $filename ) {
3636 $this->hash = $hash;
3737 $this->filename = $filename;
3838 }
Index: trunk/phase3/includes/specials/SpecialUncategorizedcategories.php
——@@ -27,7 +27,7 @@
2828 * @ingroup SpecialPage
2929 */
3030 class UncategorizedCategoriesPage extends UncategorizedPagesPage {
31 - function UncategorizedCategoriesPage() {
 31+ function __construct() {
3232 $this->requestedNamespace = NS_CATEGORY;
3333 }
3434
Index: trunk/phase3/includes/specials/SpecialMIMEsearch.php
——@@ -30,7 +30,7 @@
3131 class MIMEsearchPage extends QueryPage {
3232 var $major, $minor;
3333
34 - function MIMEsearchPage( $major, $minor ) {
 34+ function __construct( $major, $minor ) {
3535 $this->major = $major;
3636 $this->minor = $minor;
3737 }
Index: trunk/phase3/includes/specials/SpecialWantedpages.php
——@@ -29,7 +29,7 @@
3030 class WantedPagesPage extends WantedQueryPage {
3131 var $nlinks;
3232
33 - function WantedPagesPage( $inc = false, $nlinks = true ) {
 33+ function __construct( $inc = false, $nlinks = true ) {
3434 $this->setListoutput( $inc );
3535 $this->nlinks = $nlinks;
3636 }
Index: trunk/phase3/includes/specials/SpecialUserlogin.php
——@@ -68,7 +68,7 @@
6969 * @param $request WebRequest: a WebRequest object passed by reference
7070 * @param $par String: subpage parameter
7171 */
72 - function LoginForm( &$request, $par = '' ) {
 72+ function __construct( &$request, $par = '' ) {
7373 global $wgAuth, $wgHiddenPrefs, $wgEnableEmail, $wgRedirectOnLogin;
7474
7575 $this->mType = ( $par == 'signup' ) ? $par : $request->getText( 'type' ); # Check for [[Special:Userlogin/signup]]
Index: trunk/phase3/profileinfo.php
——@@ -83,7 +83,7 @@
8484 var $time;
8585 var $children;
8686
87 - function profile_point( $name, $count, $time, $memory ) {
 87+ function __construct( $name, $count, $time, $memory ) {
8888 $this->name = $name;
8989 $this->count = $count;
9090 $this->time = $time;
Index: trunk/phase3/languages/Language.php
——@@ -38,7 +38,7 @@
3939 */
4040 class FakeConverter {
4141 var $mLang;
42 - function FakeConverter( $langobj ) { $this->mLang = $langobj; }
 42+ function __construct( $langobj ) { $this->mLang = $langobj; }
4343 function autoConvertToAllVariants( $text ) { return array( $this->mLang->getCode() => $text ); }
4444 function convert( $t ) { return $t; }
4545 function convertTitle( $t ) { return $t->getPrefixedText(); }

Follow-up revisions

RevisionCommit summaryAuthorDate
r73529Followup r71961, more php4 constructorsdemon13:54, 22 September 2010
r77400Followup r71961, fix 2 leftover calls to SpecialPage::SpecialPagedemon20:55, 28 November 2010
r78192Fix for r71961 (moved SpecialPage constructor from named to __construct()). I...demon15:15, 10 December 2010
r81704Fix use of old-style constructor, broken due to r71961 tweaksbrion10:08, 8 February 2011
r81705Fix use of old-style constructor, broken due to r71961 tweaksbrion10:09, 8 February 2011
r81706Fixes for r71961tstarling10:10, 8 February 2011

Comments

#Comment by Hashar (talk | contribs)   20:59, 26 November 2010

marking fixme : bug 26132 : SpecialPage:SpecialPage might be used by extensions

follow up on bug report.

#Comment by 😂 (talk | contribs)   15:31, 13 December 2010

Should be resolved with r78192.

Status & tagging log