r78560 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78559‎ | r78560 | r78561 >
Date:13:57, 18 December 2010
Author:churchofemacs
Status:ok
Tags:
Comment:
Fixing r65339: makeTitleSafe instead of newFromText
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -264,7 +264,7 @@
265265
266266 # Give a notice if the user is uploading a file that has been deleted or moved
267267 # Note that this is independent from the message 'filewasdeleted' that requires JS
268 - $desiredTitleObj = Title::newFromText( $this->mDesiredDestName, NS_FILE );
 268+ $desiredTitleObj = Title::makeTitleSafe( NS_FILE, $this->mDesiredDestName );
269269 $delNotice = ''; // empty by default
270270 if ( $desiredTitleObj instanceof Title && !$desiredTitleObj->exists() ) {
271271 LogEventsList::showLogExtract( $delNotice, array( 'delete', 'move' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r798151.17: MFT r78327, r78560, r79131, r79708, r79713, r79725, r79758, r79759, r79...catrope13:55, 7 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65339When visiting a 'red link' of a deleted file, a deletion and move log excerpt...churchofemacs20:30, 20 April 2010

Status & tagging log