r78327 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r78326‎ \| r78327 \| r78328 >
Date:	20:34, 13 December 2010
Author:	hartman
Status:	ok
Tags:
Comment:	Followup to r77836. Update parserTests
Modified paths:	/trunk/phase3/maintenance/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/parser/parserTests.txt
—	—	@@ -6609,38 +6609,38 @@
6610	6610	!! result
6611	6611	<ul class="gallery">
6612	6612	<li class="gallerybox" style="width: 155px"><div style="width: 155px">
6613		~~- <div style="height: 152px;">Image1.png</div>~~
	6613	+ <div style="height: 150px;">Image1.png</div>
6614	6614	<div class="gallerytext">
6615	6615	</div>
6616	6616	</div></li>
6617	6617	<li class="gallerybox" style="width: 155px"><div style="width: 155px">
6618		~~- <div style="height: 152px;">Image2.gif</div>~~
	6618	+ <div style="height: 150px;">Image2.gif</div>
6619	6619	<div class="gallerytext">
6620	6620	<p>\|\|\|\|
6621	6621	</p>
6622	6622	</div>
6623	6623	</div></li>
6624	6624	<li class="gallerybox" style="width: 155px"><div style="width: 155px">
6625		~~- <div style="height: 152px;">Image3</div>~~
	6625	+ <div style="height: 150px;">Image3</div>
6626	6626	<div class="gallerytext">
6627	6627	</div>
6628	6628	</div></li>
6629	6629	<li class="gallerybox" style="width: 155px"><div style="width: 155px">
6630		~~- <div style="height: 152px;">Image4</div>~~
	6630	+ <div style="height: 150px;">Image4</div>
6631	6631	<div class="gallerytext">
6632	6632	<p>300px\| centre
6633	6633	</p>
6634	6634	</div>
6635	6635	</div></li>
6636	6636	<li class="gallerybox" style="width: 155px"><div style="width: 155px">
6637		~~- <div style="height: 152px;">Image5.svg</div>~~
	6637	+ <div style="height: 150px;">Image5.svg</div>
6638	6638	<div class="gallerytext">
6639	6639	<p><a href="http://///////" class="external free" rel="nofollow">http://///////</a>
6640	6640	</p>
6641	6641	</div>
6642	6642	</div></li>
6643	6643	<li class="gallerybox" style="width: 155px"><div style="width: 155px">
6644		~~- <div style="height: 152px;">* image6</div>~~
	6644	+ <div style="height: 150px;">* image6</div>
6645	6645	<div class="gallerytext">
6646	6646	</div>
6647	6647	</div></li>
—	—	@@ -6661,26 +6661,26 @@
6662	6662	<ul class="gallery" style="max-width: 220px;_width: 220px;">
6663	6663	<li class='gallerycaption'>Foo <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a></li>
6664	6664	<li class="gallerybox" style="width: 95px"><div style="width: 95px">
6665		~~- <div style="height: 52px;">Nonexistant.jpg</div>~~
	6665	+ <div style="height: 70px;">Nonexistant.jpg</div>
6666	6666	<div class="gallerytext">
6667	6667	<p>caption
6668	6668	</p>
6669	6669	</div>
6670	6670	</div></li>
6671	6671	<li class="gallerybox" style="width: 95px"><div style="width: 95px">
6672		~~- <div style="height: 52px;">Nonexistant.jpg</div>~~
	6672	+ <div style="height: 70px;">Nonexistant.jpg</div>
6673	6673	<div class="gallerytext">
6674	6674	</div>
6675	6675	</div></li>
6676	6676	<li class="gallerybox" style="width: 95px"><div style="width: 95px">
6677		- <div class="thumb" style="padding: 19px 0; width: 90px;"><div style="margin-left: auto; margin-right: auto; width: 60px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="60" height="7" /></a></div></div>
	6677	+ <div class="thumb" style="width: 90px; height: 70px;"><div style="margin:31px auto;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="60" height="7" /></a></div></div>
6678	6678	<div class="gallerytext">
6679	6679	<p>some <b>caption</b> <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>
6680	6680	</p>
6681	6681	</div>
6682	6682	</div></li>
6683	6683	<li class="gallerybox" style="width: 95px"><div style="width: 95px">
6684		- <div class="thumb" style="padding: 19px 0; width: 90px;"><div style="margin-left: auto; margin-right: auto; width: 60px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="Foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="60" height="7" /></a></div></div>
	6684	+ <div class="thumb" style="width: 90px; height: 70px;"><div style="margin:31px auto;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="Foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="60" height="7" /></a></div></div>
6685	6685	<div class="gallerytext">
6686	6686	</div>
6687	6687	</div></li>
—	—	@@ -6700,7 +6700,7 @@
6701	6701	!! result
6702	6702	<ul class="gallery">
6703	6703	<li class="gallerybox" style="width: 155px"><div style="width: 155px">
6704		~~- <div style="height: 152px;">Nonexistant.jpg</div>~~
	6704	+ <div style="height: 150px;">Nonexistant.jpg</div>
6705	6705	<div class="gallerytext">
6706	6706	<p><a href="https://www.mediawiki.org/wiki/File:Nonexistant.jpg" title="File:Nonexistant.jpg">Nonexistant.jpg</a><br />
6707	6707	caption
—	—	@@ -6708,14 +6708,14 @@
6709	6709	</div>
6710	6710	</div></li>
6711	6711	<li class="gallerybox" style="width: 155px"><div style="width: 155px">
6712		~~- <div style="height: 152px;">Nonexistant.jpg</div>~~
	6712	+ <div style="height: 150px;">Nonexistant.jpg</div>
6713	6713	<div class="gallerytext">
6714	6714	<p><a href="https://www.mediawiki.org/wiki/File:Nonexistant.jpg" title="File:Nonexistant.jpg">Nonexistant.jpg</a><br />
6715	6715	</p>
6716	6716	</div>
6717	6717	</div></li>
6718	6718	<li class="gallerybox" style="width: 155px"><div style="width: 155px">
6719		- <div class="thumb" style="padding: 66px 0; width: 150px;"><div style="margin-left: auto; margin-right: auto; width: 120px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="120" height="14" /></a></div></div>
	6719	+ <div class="thumb" style="width: 150px; height: 150px;"><div style="margin:68px auto;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="120" height="14" /></a></div></div>
6720	6720	<div class="gallerytext">
6721	6721	<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" title="File:Foobar.jpg">Foobar.jpg</a><br />
6722	6722	some <b>caption</b> <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>
—	—	@@ -6723,7 +6723,7 @@
6724	6724	</div>
6725	6725	</div></li>
6726	6726	<li class="gallerybox" style="width: 155px"><div style="width: 155px">
6727		- <div class="thumb" style="padding: 66px 0; width: 150px;"><div style="margin-left: auto; margin-right: auto; width: 120px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="Foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="120" height="14" /></a></div></div>
	6727	+ <div class="thumb" style="width: 150px; height: 150px;"><div style="margin:68px auto;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="Foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="120" height="14" /></a></div></div>
6728	6728	<div class="gallerytext">
6729	6729	<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" title="File:Foobar.jpg">Foobar.jpg</a><br />
6730	6730	</p>

Follow-up revisions

Revision	Commit summary	Author	Date
r79815	1.17: MFT r78327, r78560, r79131, r79708, r79713, r79725, r79758, r79759, r79...	catrope	13:55, 7 January 2011

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r77836	Follow up to r77411. Patch by DieBuche...	hartman	22:41, 5 December 2010

Status & tagging log

13:55, 7 January 2011 Catrope (talk | contribs) changed the tags for r78327 [removed: 1.17]
12:53, 7 January 2011 Catrope (talk | contribs) changed the status of r78327 [removed: new added: ok]
00:01, 7 January 2011 Platonides (talk | contribs) changed the tags for r78327 [added: 1.17]