r78352 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78351‎ | r78352 | r78353 >
Date:00:29, 14 December 2010
Author:pdhanda
Status:ok
Tags:
Comment:
Merged r77844 and r77845 from trunk
Modified paths:
  • /branches/priyanka-wmf-fixes/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /branches/priyanka-wmf-fixes/extensions/FlaggedRevs/client/flaggedrevs.js (modified) (history)
  • /branches/priyanka-wmf-fixes/extensions/FlaggedRevs/client/review.js (modified) (history)

Diff [purge]

Index: branches/priyanka-wmf-fixes/extensions/FlaggedRevs/FlaggedRevs.php
@@ -255,7 +255,7 @@
256256 $wgAvailableRights[] = 'stablesettings';
257257
258258 # Bump this number every time you change flaggedrevs.css/flaggedrevs.js
259 -$wgFlaggedRevStyleVersion = 83;
 259+$wgFlaggedRevStyleVersion = 84;
260260
261261 $wgExtensionFunctions[] = 'efLoadFlaggedRevs';
262262
Index: branches/priyanka-wmf-fixes/extensions/FlaggedRevs/client/flaggedrevs.js
@@ -164,7 +164,7 @@
165165 if( checkbox ) {
166166 checkbox.onclick = FlaggedRevs.updateSaveButton;
167167 }
168 -}
 168+};
169169
170170 FlaggedRevs.updateSaveButton = function() {
171171 var checkbox = document.getElementById("wpReviewEdit");
@@ -180,7 +180,7 @@
181181 save.title = FlaggedRevs.messages.tooltipSubmit;
182182 }
183183 }
184 -}
 184+};
185185
186186 FlaggedRevs.getRevisionContents = function() {
187187 //get the contents div and replace it with actual parsed article contents via an API call.
@@ -233,21 +233,21 @@
234234 if ( call ) {
235235 call.abort();
236236 }
237 - }
 237+ };
238238 }
239239 if ( nextLink ) {
240240 nextLink.onclick = function() {
241241 if ( call ) {
242242 call.abort();
243243 }
244 - }
 244+ };
245245 }
246 -}
 246+};
247247
248248 FlaggedRevs.setJSTriggers = function() {
249249 FlaggedRevs.enableShowhide();
250250 FlaggedRevs.setCheckTrigger();
251251 FlaggedRevs.getRevisionContents();
252 -}
 252+};
253253
254254 window.onload = FlaggedRevs.setJSTriggers;
Index: branches/priyanka-wmf-fixes/extensions/FlaggedRevs/client/review.js
@@ -60,7 +60,7 @@
6161
6262 // Update colors of <select>
6363 FlaggedRevs.updateRatingFormColors();
64 -}
 64+};
6565
6666 /*
6767 * Disable 'accept' button if the revision was already reviewed
@@ -73,7 +73,7 @@
7474 asubmit.disabled = 'disabled';
7575 }
7676 }
77 -}
 77+};
7878
7979 hookEvent( "load", FlaggedRevs.maybeDisableAcceptButton );
8080
@@ -91,7 +91,7 @@
9292 }
9393 }
9494 }
95 -}
 95+};
9696
9797 hookEvent( "load", FlaggedRevs.updateRatingFormColors );
9898
@@ -307,7 +307,7 @@
308308 if( diffHeaderItems && response != '' ) {
309309 diffHeaderItems.innerHTML = response;
310310 }
311 -}
 311+};
312312
313313 wgAjaxReview.onLoad = function() {
314314 var asubmit = document.getElementById("mw-fr-submit-accept");

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77844Bracket cleanupaaron23:31, 5 December 2010
r77845More bracket cleanupaaron23:35, 5 December 2010

Status & tagging log