r78230 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78229‎ | r78230 | r78231 >
Date:22:44, 11 December 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Follow up r77981,r77982. Rename the new globalcsspreview/globaljspreview to sitecsspreview/sitejspreview per CodeReview.
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -565,8 +565,8 @@
566566 'userjsyoucanpreview',
567567 'usercsspreview',
568568 'userjspreview',
569 - 'globalcsspreview',
570 - 'globaljspreview',
 569+ 'sitecsspreview',
 570+ 'sitejspreview',
571571 'userinvalidcssjstitle',
572572 'updated',
573573 'note',
Index: trunk/phase3/includes/EditPage.php
@@ -1883,11 +1883,11 @@
18841884 if ( $this->isCssJsSubpage || $this->mTitle->isCssOrJsPage() ) {
18851885 $level = 'user';
18861886 if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
1887 - $level = 'global';
 1887+ $level = 'site';
18881888 }
18891889
18901890 # Used messages to make sure grep find them:
1891 - # usercsspreview, userjspreview, globalcsspreview, globaljspreview
 1891+ # Messages: usercsspreview, userjspreview, sitecsspreview, sitejspreview
18921892 if (preg_match( "/\\.css$/", $this->mTitle->getText() ) ) {
18931893 $previewtext = "<div id='mw-{$level}csspreview'>\n" . wfMsg( "{$level}csspreview" ) . "\n</div>";
18941894 $class = "mw-code mw-css";
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -841,8 +841,8 @@
842842 'userjsyoucanpreview' => 'Text displayed on every js page.',
843843 'usercsspreview' => 'Text displayed on preview of every user .css subpage',
844844 'userjspreview' => 'Text displayed on preview of every user .js subpage',
845 -'globalcsspreview' => 'Text displayed on preview of .css pages in MediaWiki namespace',
846 -'globaljspreview' => 'Text displayed on preview of .js pages in MediaWiki namespace',
 845+'sitecsspreview' => 'Text displayed on preview of .css pages in MediaWiki namespace',
 846+'sitejspreview' => 'Text displayed on preview of .js pages in MediaWiki namespace',
847847 'updated' => '{{Identical|Updated}}',
848848 'previewnote' => 'Note displayed when clicking on Show preview',
849849 'editing' => "Shown as page title when editing a page. \$1 is the name of the page that is being edited. Example: \"''Editing Main Page''\".",
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1300,9 +1300,9 @@
13011301 '''It has not yet been saved!'''",
13021302 'userjspreview' => "'''Remember that you are only testing/previewing your user JavaScript.'''
13031303 '''It has not yet been saved!'''",
1304 -'globalcsspreview' => "'''Remember that you are only previewing this global CSS.'''
 1304+'sitecsspreview' => "'''Remember that you are only previewing this global CSS.'''
13051305 '''It has not yet been saved!'''",
1306 -'globaljspreview' => "'''Remember that you are only previewing this global JavaScript code.'''
 1306+'sitejspreview' => "'''Remember that you are only previewing this global JavaScript code.'''
13071307 '''It has not yet been saved!'''",
13081308 'userinvalidcssjstitle' => "'''Warning:''' There is no skin \"\$1\".
13091309 Custom .css and .js pages use a lowercase title, e.g. {{ns:user}}:Foo/vector.css as opposed to {{ns:user}}:Foo/Vector.css.",

Follow-up revisions

RevisionCommit summaryAuthorDate
r78403Remove the word global from the messages itselves, per r78230 CR.platonides21:57, 14 December 2010
r784371.17: Merge tagged revisions from trunk: r77878, r77981, r77982, r77994, r780...catrope14:14, 15 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77981Show the source on preview for CSS and Javascript pages....platonides14:53, 7 December 2010
r77982Follow up r77981platonides14:55, 7 December 2010

Comments

#Comment by Catrope (talk | contribs)   21:46, 14 December 2010

This misses the point: it renames the messages but doesn't change their contents.

#Comment by Platonides (talk | contribs)   21:57, 14 December 2010

I thought the point was in the message name. Fixed in r78403.

Status & tagging log