r77700 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77699‎ | r77700 | r77701 >
Date:00:46, 4 December 2010
Author:catrope
Status:resolved
Tags:
Comment:
Fix serious bug in comment watcher feature that exposed the commenter's IP in the e-mail to the mailing list. Renamed $wgCodeReviewCommentWatcher to $wgCodeReviewCommentWatcherEmail and introduced $wgCodeReviewCommentWatcherName , set to a non-empty default value for paranoia.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.php (modified) (history)
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.php
@@ -144,7 +144,9 @@
145145 $wgCodeReviewENotif = false;
146146
147147 // Set this to an e-mail list to send all comments to
148 -$wgCodeReviewCommentWatcher = false;
 148+$wgCodeReviewCommentWatcherEmail = false;
 149+// Name to use in the To: header of e-mails to the list. Ignored if $wgCodeReviewCommentWatcherEmail isn't set
 150+$wgCodeReviewCommentWatcherName = "CodeReview comments list";
149151
150152 // What images can be used for client-side side-by-side comparisons?
151153 $wgCodeReviewImgRegex = '/\.(png|jpg|jpeg|gif)$/i';
Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -462,7 +462,8 @@
463463 // If we've got a spam list, send e-mails to it too
464464 if ( $wgCodeReviewCommentWatcher ) {
465465 $watcher = new User();
466 - $watcher->setEmail( $wgCodeReviewCommentWatcher );
 466+ $watcher->setEmail( $wgCodeReviewCommentWatcherEmail );
 467+ $watcher->setName( $wgCodeReviewCommentWatcherName );
467468 $users[0] = $watcher; // We don't have any anons, so using 0 is safe
468469 }
469470

Follow-up revisions

RevisionCommit summaryAuthorDate
r777011.16wmf4: MFT r77700catrope00:47, 4 December 2010
r77704Fix r77700, globals *grumble*catrope00:54, 4 December 2010
r77707Another stupid fix for r77700. This is why I really shouldn't mess around wit...catrope01:01, 4 December 2010

Status & tagging log