r77699 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77698‎ | r77699 | r77700 >
Date:00:40, 4 December 2010
Author:catrope
Status:ok
Tags:
Comment:
1.16wmf4: MFT r77698 (by hand, since the code is different between 1.16wmf4 and trunk)
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/CodeReview (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CodeReview/backend/CodeRevision.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/CodeReview/backend/CodeRevision.php
@@ -432,7 +432,9 @@
433433 continue;
434434 }
435435
436 - if ( $user->canReceiveEmail() ) {
 436+ // canReceiveEmail() returns false for the fake watcher user, so exempt it
 437+ // This is ugly
 438+ if ( $userId == 0 || $user->canReceiveEmail() ) {
437439 // Send message in receiver's language
438440 $lang = array( 'language' => $user->getOption( 'language' ) );
439441
Property changes on: branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionView.php
___________________________________________________________________
Modified: svn:mergeinfo
440442 Merged /trunk/extensions/CodeReview/ui/CodeRevisionView.php:r77698
Property changes on: branches/wmf/1.16wmf4/extensions/CodeReview
___________________________________________________________________
Modified: svn:mergeinfo
441443 Merged /trunk/extensions/CodeReview:r77698

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77698Fix $wgCodeReviewCommentWatcher , didn't actually work because canReceiveEmai...catrope00:37, 4 December 2010

Status & tagging log