r77358 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77357‎ | r77358 | r77359 >
Date:15:25, 27 November 2010
Author:reedy
Status:reverted
Tags:
Comment:
Create instance of Maintenance class after AutoLoader and Defines

Reason: We might want to use class stuff in the Maintenance constructor (re r77355)
Modified paths:
  • /trunk/phase3/maintenance/doMaintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/doMaintenance.php
@@ -40,16 +40,6 @@
4141 return;
4242 }
4343
44 -// Get an object to start us off
45 -$maintenance = new $maintClass();
46 -
47 -// Basic sanity checks and such
48 -$maintenance->setup();
49 -
50 -// We used to call this variable $self, but it was moved
51 -// to $maintenance->mSelf. Keep that here for b/c
52 -$self = $maintenance->getName();
53 -
5444 # Setup the profiler
5545 global $IP;
5646 if ( file_exists( "$IP/StartProfiler.php" ) ) {
@@ -62,6 +52,16 @@
6353 require_once( "$IP/includes/AutoLoader.php" );
6454 require_once( "$IP/includes/Defines.php" );
6555
 56+// Get an object to start us off
 57+$maintenance = new $maintClass();
 58+
 59+// Basic sanity checks and such
 60+$maintenance->setup();
 61+
 62+// We used to call this variable $self, but it was moved
 63+// to $maintenance->mSelf. Keep that here for b/c
 64+$self = $maintenance->getName();
 65+
6666 if ( defined( 'MW_CONFIG_CALLBACK' ) ) {
6767 # Use a callback function to configure MediaWiki
6868 require_once( "$IP/includes/DefaultSettings.php" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r77359Revert r77358, didn't have intended affect, and broke unittestsreedy15:35, 27 November 2010
r77362Seeing as we can't do that with how maintenance is setup (see bug 26143), exp...reedy17:13, 27 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77355(bug 25505) Write maintenance script to bulk update status'...reedy14:21, 27 November 2010

Status & tagging log