r77359 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77358‎ | r77359 | r77360 >
Date:15:35, 27 November 2010
Author:reedy
Status:ok
Tags:
Comment:
Revert r77358, didn't have intended affect, and broke unittests
Modified paths:
  • /trunk/phase3/maintenance/doMaintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/doMaintenance.php
@@ -40,6 +40,16 @@
4141 return;
4242 }
4343
 44+// Get an object to start us off
 45+$maintenance = new $maintClass();
 46+
 47+// Basic sanity checks and such
 48+$maintenance->setup();
 49+
 50+// We used to call this variable $self, but it was moved
 51+// to $maintenance->mSelf. Keep that here for b/c
 52+$self = $maintenance->getName();
 53+
4454 # Setup the profiler
4555 global $IP;
4656 if ( file_exists( "$IP/StartProfiler.php" ) ) {
@@ -52,16 +62,6 @@
5363 require_once( "$IP/includes/AutoLoader.php" );
5464 require_once( "$IP/includes/Defines.php" );
5565
56 -// Get an object to start us off
57 -$maintenance = new $maintClass();
58 -
59 -// Basic sanity checks and such
60 -$maintenance->setup();
61 -
62 -// We used to call this variable $self, but it was moved
63 -// to $maintenance->mSelf. Keep that here for b/c
64 -$self = $maintenance->getName();
65 -
6666 if ( defined( 'MW_CONFIG_CALLBACK' ) ) {
6767 # Use a callback function to configure MediaWiki
6868 require_once( "$IP/includes/DefaultSettings.php" );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77358Create instance of Maintenance class after AutoLoader and Defines...reedy15:25, 27 November 2010

Status & tagging log